Remove unnessary Copy and Send impls #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1492 +/- ##
=======================================
Coverage 91.80% 91.80%
=======================================
Files 40 40
Lines 18329 18336 +7
=======================================
+ Hits 16827 16834 +7
Misses 1502 1502 ☔ View full report in Codecov by Sentry. |
Fuchsia is doing an audit of chrono 0.4.34, and we noticed an unncessary unsafe of `Send` for `DateTime`. While it's valid since `Tz::Offset` is `Send`, and `NaiveDateTime` only has `u32` fields, there's a potential hazard if `NaiveDateTime` ever grows unsendable fields (unlikely as that is). This (and the `Copy` impl) were added 9 years ago to fix chronotope#25, which stemmed from early versions of associate traits not working properly with auto-traits. This has since been fixed, and is no longer necessary with the MSRV 1.61.0.
pitdicker
reviewed
Mar 7, 2024
| @@ -1866,3 +1866,12 @@ fn nano_roundrip() { | |||
| assert_eq!(nanos, nanos2); | |||
| } | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_datetime_utc_is_copy_and_send() { | |||
There was a problem hiding this comment.
We have the same test ca. 600 lines above.
Merged
|
Removing the duplicate test in #1494. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuchsia is doing an audit of chrono 0.4.34, and we noticed an unncessary unsafe of
SendforDateTime. While it's valid sinceTz::OffsetisSend, andNaiveDateTimeonly hasu32fields, there's a potential hazard ifNaiveDateTimeever grows unsendable fields (unlikely as that is).This (and the
Copyimpl) were added 9 years ago to fix #25, which stemmed from early versions of associate traits not working properly with auto-traits. This has since been fixed, and is no longer necessary with the MSRV 1.61.0.To make sure this stays working, it includes a test that makes sure that
DateTime<Utc>isSendandCopyjust to be safe.