Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate test #1494

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Remove duplicate test #1494

merged 1 commit into from
Mar 7, 2024

Conversation

djc
Copy link
Member

@djc djc commented Mar 7, 2024

Follow-up from #1492. Should have known better than to merge without @pitdicker's review!

@djc djc requested a review from pitdicker March 7, 2024 08:28
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.80%. Comparing base (e79fe21) to head (3b3e046).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1494      +/-   ##
==========================================
- Coverage   91.80%   91.80%   -0.01%     
==========================================
  Files          40       40              
  Lines       18336    18329       -7     
==========================================
- Hits        16834    16827       -7     
  Misses       1502     1502              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pitdicker pitdicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha. You had a productive night!

@djc djc merged commit bcb5386 into main Mar 7, 2024
35 checks passed
@djc djc deleted the rm-duplicate-test branch March 7, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants