Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cilium install --version doesn't let you install snapshot versions. #1448

Closed
jspaleta opened this issue Mar 10, 2023 · 1 comment · Fixed by #1452
Closed

cilium install --version doesn't let you install snapshot versions. #1448

jspaleta opened this issue Mar 10, 2023 · 1 comment · Fixed by #1452
Assignees
@tklauser
Labels
kind/bug Something isn't working

Comments

@jspaleta
Copy link

Bug report

cilium install --list-versions includes v1.14.0-snapshot.0

But cilium install --version "v1.14.0-snapshot.0" results in error
invalid parameters: invalid syntax "v1.14.0-snapshot.0" for image tag

Looks like the version argument linting is too restrictive to allow the new snapshot version concept.

General Information

  • Cilium CLI version
$ cilium version
cilium-cli: v0.13.1 compiled with go1.20 on linux/amd64
cilium image (default): v1.13.0
cilium image (stable): v1.13.0
cilium image (running): unknown. Unable to obtain cilium version, no cilium pods found in namespace "kube-system"
  • Orchestration system version in use (e.g. kubectl version, ...)
kubectl version
WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"26", GitVersion:"v1.26.1", GitCommit:"8f94681cd294aa8cfd3407b8191f6c70214973a4", GitTreeState:"clean", BuildDate:"2023-01-18T15:58:16Z", GoVersion:"go1.19.5", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.3", GitCommit:"434bfd82814af038ad94d62ebe59b133fcb50506", GitTreeState:"clean", BuildDate:"2022-10-25T19:35:11Z", GoVersion:"go1.19.2", Compiler:"gc", Platform:"linux/amd64"}
  • Platform / infrastructure information (e.g. AWS / Azure / GCP, image / kernel versions)
  • Link to relevant artifacts (policies, deployments scripts, ...)
  • Generate and upload a system zip: cilium sysdump

How to reproduce the issue

  1. Attempt to install any snapshot version listed in the output of cilium install --list-versions
@jspaleta jspaleta added the kind/bug Something isn't working label Mar 10, 2023
@tklauser tklauser self-assigned this Mar 10, 2023
@tklauser
Copy link
Member

Thanks for the report @jspaleta. I can confirm the issue and I'm working on a fix.

@tklauser tklauser mentioned this issue Mar 10, 2023
Merged
tklauser added a commit to cilium/cilium that referenced this issue Mar 10, 2023
@tklauser
versioncheck: fix parsing of snapshot release versions
d7f973b 
For the Cilium v1.14 release cycle we started doing snapshot releases
which are tagged in the format vX.Y.Z-snapshotN. Let
versioncheck.Version accept this version format.

For cilium/cilium-cli#1448

Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser added a commit to cilium/cilium that referenced this issue Mar 13, 2023
@tklauser
versioncheck: fix parsing of snapshot release versions
7087445 
For the Cilium v1.14 release cycle we started doing snapshot releases
which are tagged in the format vX.Y.Z-snapshotN. Let
versioncheck.Version accept this version format.

For cilium/cilium-cli#1448

Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser added a commit that referenced this issue Mar 14, 2023
@tklauser
go.mod, vendor: update cilium to latest master to pull in versionchec…
c2d20e2 
…k fix

cilium-cli uses the github.com/cilium/cilium/pkg/versioncheck package to
parse Cilium versions. In the latest version, this package was fixed to
allow parsing snapshot release versions, cf.
cilium/cilium#24286

For #1448

Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser added a commit that referenced this issue Mar 14, 2023
@tklauser
internal/utils: match new snapshot release version format
49a38bb 
Currently, installing snapshot version results in an error:

   $ cilium install --version v1.14.0-snapshot.0
   invalid parameters: invalid syntax "v1.14.0-snapshot.0" for image tag

Fix it by allowing dots in the part after the dash.

Fixes #1448

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser mentioned this issue Mar 14, 2023
Merged
tklauser added a commit that referenced this issue Mar 15, 2023
@tklauser
go.mod, vendor: update cilium to latest master to pull in versionchec…
a2675df 
…k fix

cilium-cli uses the github.com/cilium/cilium/pkg/versioncheck package to
parse Cilium versions. In the latest version, this package was fixed to
allow parsing snapshot release versions, cf.
cilium/cilium#24286

For #1448

Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser added a commit that referenced this issue Mar 15, 2023
@tklauser
internal/utils: match new snapshot release version format
a2058ff 
Currently, installing snapshot version results in an error:

   $ cilium install --version v1.14.0-snapshot.0
   invalid parameters: invalid syntax "v1.14.0-snapshot.0" for image tag

Fix it by allowing dots in the part after the dash.

Fixes #1448

Signed-off-by: Tobias Klauser <tobias@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tklauser tklauser

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow installing Cilium snapshot versions cilium/cilium-cli
2 participants
@jspaleta @tklauser