Allow installing Cilium snapshot versions #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k fix cilium-cli uses the github.com/cilium/cilium/pkg/versioncheck package to parse Cilium versions. In the latest version, this package was fixed to allow parsing snapshot release versions, cf. cilium/cilium#24286 For #1448 Signed-off-by: Tobias Klauser <tobias@cilium.io>
This allows to get rid of some boilerplate and de-duplicate the error message. Signed-off-by: Tobias Klauser <tobias@cilium.io>
Currently, installing snapshot version results in an error: $ cilium install --version v1.14.0-snapshot.0 invalid parameters: invalid syntax "v1.14.0-snapshot.0" for image tag Fix it by allowing dots in the part after the dash. Fixes #1448 Signed-off-by: Tobias Klauser <tobias@cilium.io>
sayboras
approved these changes
Mar 14, 2023
chancez
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit updates the vendored
github.com/cilium/ciliumpackages to latestmasterto pull in cilium/cilium#24286.The second commit refactors
internal/utils.CheckVersionto avoid some boilerplate and to de-duplicate the error message returned upon failure to parse a version.The third commit fixes matching of snapshot releases in cilium-cli.
With the
ciliumbinary installed from this PR, Cilium 1.14.0-snapshot.0 can be installed as expected:/cc @jspaleta
Fixes #1448