Add a template #84
Merged
Add a template #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgsloan
reviewed
Apr 16, 2018
etc/template/LICENSE
Outdated
| @@ -0,0 +1,30 @@ | |||
| Copyright Author name here (c) 2018 | |||
There was a problem hiding this comment.
Should probably be AUTHOR not Author name here
|
LGTM. I like the make-template.hs stuff. It's kinda humorous to use |
roman
reviewed
Apr 16, 2018
etc/template/package.yaml
Outdated
|
|
||
| dependencies: | ||
| - base >= 4.10 && < 5 | ||
| - rio >= 0.1.1.0 && < 0.2 |
There was a problem hiding this comment.
Wondering why the upper-bound here?
There was a problem hiding this comment.
Good point, I've removed it.
roman
reviewed
Apr 16, 2018
| readProcessStdout_ | ||
| files <- mapM decode $ splitNulls $ BL.toStrict rawout | ||
| let src = forM_ files $ \fp -> yield (fp, readFileBinary $ templatedir </> fp) | ||
| runConduitRes $ src .| createTemplate .| sinkFile "rio.hsfiles" |
There was a problem hiding this comment.
Oh 🙀🙀🙀 this is awesome! No longer nasty huge hsfiles, I'm copying this to my dotfiles like yesterday! No longer generating Makefiles with the wrong spacing 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended for usage with
stack new. The code here is certainly up for improvement.