fix macos sdk --- UNTESTED #201
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
| @@ -1,5 +1,5 @@ | |||
| {% set name = "conda-forge-ci-setup" %} | |||
| {% set version = "3.20.1" %} | |||
| {% set version = "3.21.0" %} | |||
There was a problem hiding this comment.
minor or patch release??
| curl -L -O https://github.com/phracker/MacOSX-SDKs/releases/download/11.3/MacOSX${MACOSX_SDK_VERSION}.sdk.tar.xz | ||
| mkdir -p "$(dirname "$CONDA_BUILD_SYSROOT")" | ||
| tar -xf MacOSX${MACOSX_SDK_VERSION}.sdk.tar.xz -C "$(dirname "$CONDA_BUILD_SYSROOT")" | ||
| if [[ ${MACOSX_SDK_VERSION} == 12.* ]]; then |
There was a problem hiding this comment.
Does this logic even work?
There was a problem hiding this comment.
maybe. you can put it in quotes too.
There was a problem hiding this comment.
we are only missing three of them btw, 12.0, 12.1, and 12.3
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-ci-setup-feedstock/actions/runs/2402456465. |
|
Are you able to upload this to your channel and then depend on your channel in addition to conda forges for some builds? |
I should first test it like this, right? I will try to do that |
|
It will be good to hear from people about this in general. The vmImages from Azure do provide a selection of SDKs, and they're (I think) are organized based on support. So macos-11 will get you a number of them (quite a few), and macos-12 will get you the three missing ones here, 12.* (macos-11 does have 12.0 and 12.1, but I need to double check) The problem in my pytorch PR is that I am trying to do it hands-off and the build is getting confused* (i.e. told by macos-12 to set up sdk12.3 but told by conda-forge to set up sdk11.0, so the headers, etc are all over the place --- I could tidy it up there, but it would be good to pursue a unified strategy) *confused because it is deciding certain cmake/make args based on the availability of sdks |
fixes #200
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)