try v1.12 #118
Closed
try v1.12 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender. |
…nda-forge-pinning 2022.06.13.22.29.59
|
@conda-forge-admin, please rerender |
|
@conda-forge-admin, please rerender. |
…nda-forge-pinning 2022.06.13.22.29.59
|
Never noticed this before... |
|
@hmaarrfk this is the |
|
This is likely the issue: pytorch/pytorch#75398 Why don't we pull https://github.com/conda-forge/onednn-feedstock/blob/main/recipe/meta.yaml? |
|
I'm not sure what we are pulling. Generally this recipe is hard to build. So for many reasons we don't break it up. |
|
I have no idea, it seems the issue is that these |
|
I will try to see what it would take for us to simply use the onednn feedstock instead of cloning the other. |
|
(will reopen another PR later) |
…nda-forge-pinning 2022.06.22.11.09.47
…nda-forge-pinning 2022.06.24.18.35.54
…nda-forge-pinning 2022.06.29.18.34.42
ngam
commented
Jun 29, 2022
| @@ -1,4 +1,7 @@ | |||
| azure: | |||
| settings_osx: | |||
| pool: | |||
| vmImage: macos-12 | |||
There was a problem hiding this comment.
@isuruf, is this safe? The advantage of setting macos-12 here is to get the highest sdks and that enables MPS by default. However, I could see this being problematic breaking builds for macos < 12. What do you think?
There should be an alternative way where we can force it to build for MPS, but the logic upstream is pretty inconvenient: https://github.com/pytorch/pytorch/blob/b370959da11fe1c5fe9a6a6335a9b10ab6ad0a39/CMakeLists.txt#L90-L124. We can potentially just patch this and force it to build, but that may be risky.
That's why I initially opted to separate them. Keep the status quo for our regular build and add a highly constrained MPS build with the "MPS"/"Metal" tag
There was a problem hiding this comment.
Also note, we don't have SDKs >= 12 in conda-forge. I submitted (and closed) a PR for that initially before deciding it was easier to just split them. Here's the PR: conda-forge/conda-forge-ci-setup-feedstock#201
|
these issues persist, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this dev PR is:
xref #107
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)