Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Travis snapshots deploy for pull requests #546

Merged
merged 1 commit into from
Jun 24, 2013

Conversation

paoloambrosio
Copy link
Member

As @brasmusson pointed out in #536, Travis should not try to deploy snapshots for pull requests. This pull request should enable deploy when they are merged only.

Some concerns:

  • Anyone could re-enable it by commenting out those lines and sending a pull request
  • Each artifact is deployed as soon as the tests pass, but I think they should be deployed only if the entire build succeeds (after_success phase)

aslakhellesoy added a commit that referenced this pull request Jun 24, 2013
Disable Travis snapshots deploy for pull requests
@aslakhellesoy aslakhellesoy merged commit 55192d3 into cucumber:master Jun 24, 2013
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants