-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additionally deploy the cucumber-android jar. #586
Conversation
I wonder - should we add something similar for |
I don't think the jar should be installed to the local repository because maven-android-plugin only uses apklib for dependencies. I actually tried building just a jar instead of the apklib but maven-android-plugin refused to work with a jar as the dependency for cucmber-android (in the example projects). I posted a question to the authors of the plugin on their mailing list but they haven't responded yet. |
Hm, it's not so easy. Maybe the maven-deploy-plugin needs special configuration regarding the login credentials?
|
It has never worked (and probably should not work) to deploy from pull requests (see #546). The profiles |
@brasmusson, you're right, that's only logical. Do you know of a way how I can test this on my machine, maybe by deploying to a local repository? |
I don't have a good idea of how to test it. Even though I was one of the first to run into the fact that deploy does not work from pull requests, I'm not exactly sure way it doesn't work. But since we don't want to deploy from pull requests, it is kind of a good thing that it doesn't work if we try. |
It is possible that the reason I got an error in PR536 (when the deployment was not disabled for pull requests), was that it the time I did not have push access to Cucumber-JVM. So with that access it would be possible to deploy from pull requests, even though it in the end is not something you want to do. Maybe, or maybe not. |
@mfellner just work on master. We can live with a few intermittent build failures. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This should potentially cause Maven to also deploy the jar for cucumber-android (#573).
Sending a pull request in order to try this out on Travis first.