Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additionally deploy the cucumber-android jar. #586

Merged
merged 3 commits into from
Sep 12, 2013
Merged

Conversation

mfellner
Copy link
Contributor

@mfellner mfellner commented Sep 9, 2013

This should potentially cause Maven to also deploy the jar for cucumber-android (#573).

Sending a pull request in order to try this out on Travis first.

@aslakhellesoy
Copy link
Contributor

I wonder - should we add something similar for install so that mvn install also installs the jar in the local repo?

@mfellner
Copy link
Contributor Author

mfellner commented Sep 9, 2013

I don't think the jar should be installed to the local repository because maven-android-plugin only uses apklib for dependencies.

I actually tried building just a jar instead of the apklib but maven-android-plugin refused to work with a jar as the dependency for cucmber-android (in the example projects).

I posted a question to the authors of the plugin on their mailing list but they haven't responded yet.

@mfellner
Copy link
Contributor Author

mfellner commented Sep 9, 2013

Hm, it's not so easy. Maybe the maven-deploy-plugin needs special configuration regarding the login credentials?

[INFO] Building jar: /home/travis/build/cucumber/cucumber-jvm/android/target/cucumber-android-1.1.5-SNAPSHOT.apklib
Sep 09, 2013 11:01:37 AM org.apache.commons.httpclient.auth.AuthChallengeProcessor selectAuthScheme
INFO: basic authentication scheme selected
Sep 09, 2013 11:01:37 AM org.apache.commons.httpclient.HttpMethodDirector processWWWAuthChallenge
INFO: No credentials available for BASIC 'Sonatype Nexus Repository Manager'@oss.sonatype.org:443
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy-file (default) on project cucumber-android: Failed to retrieve remote metadata info.cukes:cucumber-android:1.1.5-SNAPSHOT/maven-metadata.xml: Could not transfer metadata info.cukes:cucumber-android:1.1.5-SNAPSHOT/maven-metadata.xml from/to remote-repository (https://oss.sonatype.org/service/local/staging/deploy/maven2/): Not authorized. -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
The command "mvn -q deploy -P android -pl android --settings .travis-settings.xml -Dno.gem.deploy=true -Dandroid.device=test" exited with 1.
Done. Your build exited with 1.

@brasmusson
Copy link
Contributor

It has never worked (and probably should not work) to deploy from pull requests (see #546). The profiles travis-disable-deploy-by-default and travis-enable-deploy-if-not-pull-request in the top pom are used to not even try to deploy from pull requests for the other modules.

@mfellner
Copy link
Contributor Author

mfellner commented Sep 9, 2013

@brasmusson, you're right, that's only logical. Do you know of a way how I can test this on my machine, maybe by deploying to a local repository?

@brasmusson
Copy link
Contributor

I don't have a good idea of how to test it. Even though I was one of the first to run into the fact that deploy does not work from pull requests, I'm not exactly sure way it doesn't work. But since we don't want to deploy from pull requests, it is kind of a good thing that it doesn't work if we try.

@brasmusson
Copy link
Contributor

It is possible that the reason I got an error in PR536 (when the deployment was not disabled for pull requests), was that it the time I did not have push access to Cucumber-JVM. So with that access it would be possible to deploy from pull requests, even though it in the end is not something you want to do. Maybe, or maybe not.

@aslakhellesoy
Copy link
Contributor

@mfellner just work on master. We can live with a few intermittent build failures.

@aslakhellesoy aslakhellesoy merged commit e44cc9c into master Sep 12, 2013
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants