Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet-lib): optional sync of the account #1830

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

markin-io
Copy link
Contributor

@markin-io markin-io commented Apr 25, 2024

Issue being fixed or feature implemented

Introduce synchronize: bool flag into getAccount() to allow users get account info without the need to sync with the chain first. Useful in client applications

What was done?

How Has This Been Tested?

  • CI
  • Dash Web Extension

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@markin-io markin-io merged commit 122bbb9 into v1.0-dev Apr 25, 2024
27 checks passed
@markin-io markin-io deleted the feat/wallet-lib/get-account-no-sync-optional branch April 25, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants