feat(wallet-lib): optional sync of the account

packages/js-dash-sdk/src/SDK/Client/Client.ts

@@ -7,7 +7,7 @@
 import { contractId as dashpayContractId } from '@dashevo/dashpay-contract/lib/systemIds';
 import { contractId as masternodeRewardSharesContractId } from '@dashevo/masternode-reward-shares-contract/lib/systemIds';
 import { contractId as withdrawalsContractId } from '@dashevo/withdrawals-contract/lib/systemIds';
 import { Platform } from './Platform';
 import { ClientApps, ClientAppsOptions } from './ClientApps';
 
 export interface WalletOptions extends Wallet.IWalletOptions {
@@ -163,8 +163,9 @@
       throw new Error('Wallet is not initialized, pass `wallet` option to Client');
     }
 
     options = {
       index: this.defaultAccountIndex,
+      synchronize: true,
       ...options,
     };
 

packages/wallet-lib/src/types/Account/Account.d.ts

@@ -88,6 +88,7 @@ export declare interface getUTXOSOptions {
 export declare namespace Account {
     interface Options {
         index?: number,
+        synchronize?: boolean,
         network?: Network;
         debug?: boolean;
         label?: string;

packages/wallet-lib/src/types/Account/Account.js

@@ -56,6 +56,7 @@ class Account extends EventEmitter {
     if (!wallet || wallet.constructor.name !== Wallet.name) throw new Error('Expected wallet to be passed as param');
     if (!_.has(wallet, 'walletId')) throw new Error('Missing walletID to create an account');
     this.walletId = wallet.walletId;
+    this.wallet = wallet;
     this.logger = logger.getForWallet(this.walletId);
 
     this.logger.debug(`Loading up wallet ${this.walletId}`);
@@ -223,16 +224,12 @@ class Account extends EventEmitter {
     return `${EVENTS.INSTANT_LOCK}:${transactionHash}`;
   }
 
-  // It's actually Account that mutates wallet.accounts to add itself.
-  // We might want to get rid of that as it can be really confusing.
-  // It would gives that responsability to createAccount to create
-  // (and therefore push to accounts).
   async init(wallet) {
     if (this.state.isInitialized) {
       return true;
     }
     await _addAccountToWallet(this, wallet);
-    await _initializeAccount(this, wallet.plugins);
+    await _initializeAccount(this, wallet ? wallet.plugins : this.wallet.plugins);
     return true;
   }
 

packages/wallet-lib/src/types/Account/_initializeAccount.js

@@ -6,22 +6,6 @@ const preparePlugins = require('./_preparePlugins');
 async function _initializeAccount(account, userUnsafePlugins) {
   const self = account;
 
-  // Add default derivation paths
-  account.addDefaultPaths();
-
-  // Issue additional derivation paths in case we have transactions in the store
-  // at the moment of initialization (from persistent storage)
-  account.createPathsForTransactions();
-
-  // Add block headers from storage into the SPV chain if there are any
-  const chainStore = self.storage.getDefaultChainStore();
-  const { blockHeaders, lastSyncedHeaderHeight } = chainStore.state;
-  if (!self.offlineMode) {
-    const { blockHeadersProvider } = self.transport.client;
-    const firstHeaderHeight = lastSyncedHeaderHeight - blockHeaders.length + 1;
-    await blockHeadersProvider.initializeChainWith(blockHeaders, firstHeaderHeight);
-  }
-
   // We run faster in offlineMode to speed up the process when less happens.
   const readinessIntervalTime = (account.offlineMode) ? 50 : 200;
   // TODO: perform rejection with a timeout

packages/wallet-lib/src/types/Wallet/methods/createAccount.js

@@ -28,8 +28,29 @@ async function createAccount(accountOpts) {
   const opts = Object.assign(baseOpts, accountOpts);
 
   const account = new Account(this, opts);
+
+  // Add default derivation paths
+  account.addDefaultPaths();
+
+  // Issue additional derivation paths in case we have transactions in the store
+  // at the moment of initialization (from persistent storage)
+  account.createPathsForTransactions();
+
+  // Add block headers from storage into the SPV chain if there are any
+  const chainStore = this.storage.getDefaultChainStore();
+  const { blockHeaders, lastSyncedHeaderHeight } = chainStore.state;
+  if (!this.offlineMode && blockHeaders.length > 0) {
+    const { blockHeadersProvider } = this.transport.client;
+    blockHeadersProvider.initializeChainWith(blockHeaders, lastSyncedHeaderHeight);
+  }
+
+  this.accounts.push(account);
+
   try {
-    await account.init(this);
+    if (opts.synchronize) {
+      await account.init(this);
+    }
+
     return account;
   } catch (e) {
     await account.disconnect();

packages/wallet-lib/src/types/Wallet/methods/getAccount.js

@@ -2,14 +2,19 @@ const _ = require('lodash');
 const { is } = require('../../../utils');
 const EVENTS = require('../../../EVENTS');
 
+const defaultOpts = {
+  index: 0,
+  synchronize: true,
+};
+
 /**
  * Get a specific account per accounts index
  * @param accountOpts - If the account doesn't exist yet, we create it passing these options
  * @param accountOpts.index - Default: 0, set a specific index to get
+ * @param accountOpts.synchronize - Default: true, specifies whether account has to be synchronized
  * @return {Account}
  */
-
-async function getAccount(accountOpts = {}) {
+async function getAccount(accountOpts = defaultOpts) {
   if (!this.storage.configured) {
     await new Promise((resolve) => { this.storage.once(EVENTS.CONFIGURED, resolve); });
   }
@@ -27,7 +32,7 @@ async function getAccount(accountOpts = {}) {
   const baseOpts = { index: accountIndex };
 
   const opts = Object.assign(baseOpts, accountOpts);
-  return (acc[0]) || this.createAccount(opts);
+  return acc[0] || this.createAccount(opts);
 }
 
 module.exports = getAccount;