Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes frontend UI #108

Merged
merged 41 commits into from
May 6, 2022
Merged

Fixes frontend UI #108

merged 41 commits into from
May 6, 2022

Conversation

badrlarhdir
Copy link
Contributor

@badrlarhdir badrlarhdir commented May 1, 2022

  • Cleans election show (some small modifications to do like adapt the StatusTimeline)
  • Adds setTimeout to mock API calls
  • Admins table
  • Icon buttons for Actions (To review ! w/ team)
  • Redo Modal of actions
  • Adds translation for added text
  • Remove Vote page + table page
  • Redo 404 page not found
  • Redo Vote Impossible (Show.tsx ballots) page
  • Change modal of add user in Admin page
  • Changes UI for Admin RemoveRole modal
  • Loaders redone
    • App is loading
    • Election table
    • Election show
    • Ballot show
  • Removes the extra text on loading the ElectionsTable
  • Adds Title for ElectionTable
  • Same width for election table, admin, election show
  • Adds loading for Admin
  • In “add user” & "delete user' (Admin.tsx) delete console alert and replace it with flash on error
  • Remove flash buttons in the homepage
  • Adds back About on the navbar

Todo in other PRs

  • Status role-based (NOW: just in workflow, should be in election table -> useChangeStatus.tsx to change )
  • When creating returns to the election ? ( show page or elections table )
  • When casting a vote should return to ? ( show page or elections table )
  • When going back from results should return to the correct from page
  • Adds feedback (loading) on cast vote ( quick fix not working , to investigate )
  • Block Access to admin & create page if not admin/operator (using special RequireAuth for admin) + their functionalities (on the mock api)
  • Block access to the actions of an admin/operator if just a voter (using special RequireAuth for admin) + their functionalities (on the mock api)

@coveralls
Copy link

coveralls commented May 1, 2022

Pull Request Test Coverage Report for Build 2265341912

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 63.841%

Files with Coverage Reduction New Missed Lines %
services/dkg/pedersen/handler.go 13 84.84%
Totals Coverage Status
Change from base Build 2260632278: -0.3%
Covered Lines: 3088
Relevant Lines: 4837

💛 - Coveralls

@badrlarhdir badrlarhdir self-assigned this May 2, 2022
@badrlarhdir badrlarhdir requested review from cmsigrist and nkcr and removed request for nkcr and cmsigrist May 3, 2022 14:53
@badrlarhdir badrlarhdir requested review from cmsigrist and nkcr May 4, 2022 16:56
Copy link
Contributor

@nkcr nkcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, work! just small comments about error messages.

@badrlarhdir badrlarhdir requested a review from nkcr May 6, 2022 12:27
Copy link
Contributor

@nkcr nkcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM 🚀

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@badrlarhdir badrlarhdir merged commit 73b629a into main May 6, 2022
@badrlarhdir badrlarhdir deleted the front-ui-fix branch May 6, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants