-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds translation of form #237
Conversation
…o add the Hint in the 3 lan
Pull Request Test Coverage Report for Build 3952471509Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- there are some formatting issues
- there is still some mess with the dependencies: make sure to remove the
package-lock.json
, and leave the others untouched.
const { t } = useTranslation(); | ||
|
||
const handleChecks = (e: React.ChangeEvent<HTMLInputElement>, choiceIndex: number) => { | ||
const newAnswers = answersFrom(answers); | ||
let selectAnswers = newAnswers.SelectAnswers.get(select.ID); | ||
|
||
if (select.MaxN === 1) { | ||
selectAnswers = new Array<boolean>(select.Choices.length).fill(false); | ||
selectAnswers = new Array<boolean>(select.ChoicesMap.get('en').length).fill(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still got the same remark
const { t } = useTranslation(); | ||
const [charCounts, setCharCounts] = useState(new Array<number>(text.Choices.length).fill(0)); | ||
const [charCounts, setCharCounts] = useState( | ||
new Array<number>(text.ChoicesMap.get('en').length).fill(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if there is indeed the french available, how can it get displayed ?
@@ -124,7 +126,54 @@ const AddQuestionModal: FC<AddQuestionModalProps> = ({ | |||
return; | |||
} | |||
}; | |||
|
|||
/*type renderQuestionModalProps = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so it can be removed
web/frontend/src/pages/form/components/utils/useQuestionForm.ts
Outdated
Show resolved
Hide resolved
web/frontend/src/pages/form/components/utils/useQuestionForm.ts
Outdated
Show resolved
Hide resolved
…nto tagemoua-patch1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, LGTM 🚀
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to go 🚀
Add internationalization by adding the possibility to enter the form in 3 languages and having the frontend displayed on the 3 languages