Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Showing app status on app listing page #2799

Merged
merged 87 commits into from
Feb 1, 2023
Merged

feat: Showing app status on app listing page #2799

merged 87 commits into from
Feb 1, 2023

Conversation

gireesh-naidu
Copy link
Member

@gireesh-naidu gireesh-naidu commented Dec 28, 2022 •
edited
Loading

Description

Showing app statuses for devtron apps and helm apps in app listing page.

Fix #2911

In this PR we are providing app status to appear on app listing page.this app status will be available for argo-cd configured apps and envs.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@gireesh-naidu
wip
29d1057
@gireesh-naidu
rest-handler commit
7056242
@gireesh-naidu
constructors added
3f67068
@gireesh-naidu
test commit
745b01c
@gireesh-naidu
minor design change and resthandler dev
b403e22
@gireesh-naidu
getting app_name and env_name in repo layer
a8a7261 
for rbac optimisation
@gireesh-naidu
rabc checks moved to service layer for optimisation
761fbd0
@gireesh-naidu
rbac checks in batch
0a21b36
@gireesh-naidu
getting env_identifier instead of env name
9c7a0a3
@gireesh-naidu
delete and update methods completed in repo layer
da63368
@gireesh-naidu
updating app-status for applisting and cdhandler hook points
0e1528c
@gireesh-naidu
updating app-status for app-store app deployed with gitops
94b0809
@gireesh-naidu
added AppId field in InstalledAppAndEnvDetails struct
40a17c7
@gireesh-naidu
added update app status hook in fetch resource tree function
9e0c359
@gireesh-naidu
wip
5104cf6
@gireesh-naidu
merge main
4410b03
@gireesh-naidu
unstable wire
dbd58da
@gireesh-naidu
sending app_status for overview page via other env api
641bf87
@gireesh-naidu
fix
4007f64
@gireesh-naidu
added delete with appid and envid
6c443cb 
api's
@gireesh-naidu
deleted active column from db
86bb8e6
@gireesh-naidu
fix
070ab24
@gireesh-naidu
query fix
6214e20
@gireesh-naidu
query fix
26979f1
@gireesh-naidu
fix
c2994a8
@gireesh-naidu
Merge branch 'main' into app_status
dfac012
@gireesh-naidu
update hook added
1b6c755
@gireesh-naidu
fix
b28ff59
@gireesh-naidu
fix
11dff8d
@gireesh-naidu
wire
eab71e4
@gireesh-naidu gireesh-naidu marked this pull request as ready for review January 18, 2023 10:55
@gireesh-naidu gireesh-naidu changed the title Showing app status on app listing page feat: Showing app status on app listing page Jan 30, 2023
@gireesh-naidu gireesh-naidu self-assigned this Jan 31, 2023
@gireesh-naidu gireesh-naidu added the enhancement New feature or request label Jan 31, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@gireesh-naidu gireesh-naidu merged commit f1e6829 into main Feb 1, 2023
@gireesh-naidu gireesh-naidu deleted the app_status branch February 1, 2023 05:49
kartik-579 added a commit that referenced this pull request Mar 28, 2023
@kartik-579 @Shubham9t9
@ajaydevtron @prakarsh-dt @pawan-mehta-dt @gireesh-naidu @vikramdevtron
Oss sync argo upgrade (#7)
c21ddb8 
* docs: Updated README.md file for Devtron chart (#2887)

* Updated README.md file for DEvtron chart

* incorporated changes mentioned in comments

* minor spelling correction

---------

Co-authored-by: Shubham9t9 <shubhamkumar47022@gmai.com>

* removed command to install a particular version of Devtron (#2888)

Co-authored-by: Shubham9t9 <shubhamkumar47022@gmai.com>

* feat: Support of reuse container image in containers section in reference chart 4-17 (#2675)

* support of reuse conatiner image in containers section

* support of reuse container image in latest deployment and rollout chart

* added the readme

---------

Co-authored-by: Ajay Kumar <ajaykumar@Ajays-MacBook-Pro.local>

* release: PR for v0.6.11 (#2866)

* Created release-notes files

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated release notes

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated latest image of dashboard in installer

* Updated release notes

* Updated latest image of devtron in installer

* Updated latest image of dashboard in installer

* Updated latest image of hyperion in installer

* Updated latest image of dashboard in installer

* Updated release notes

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated release notes

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated latest image of ci-runner in installer

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated release notes

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated release notes

* Updated release notes

* Updated latest image of hyperion in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of hyperion in installer

* Update release.txt

* Updated latest image of git-sensor in installer

* Updated latest image of kubewatch in installer

* Updated latest image of image-scanner in installer

* Updated latest image of git-sensor in installer

* Updated latest image of ci-runner in installer

* Updated latest image of lens in installer

* Updated nats image in devtron latest release

* Update installation-script

* Updated latest image of devtron in installer

* Updated latest image of kubelink in installer

* Updated latest image of dashboard in installer

* Update values.yaml

* Updated latest image of hyperion in installer

* Updated release-notes files

* Update releasenotes.md

---------

Co-authored-by: pawan-mehta-dt <117346502+pawan-mehta-dt@users.noreply.github.com>

* feat: Showing app status on app listing page (#2799)

* wip

* rest-handler commit

* constructors added

* test commit

* minor design change and resthandler dev

* getting app_name and env_name in repo layer
for rbac optimisation

* rabc checks moved to service layer for optimisation

* rbac checks in batch

* getting env_identifier instead of env name

* delete and update methods completed in repo layer

* updating app-status for applisting and cdhandler hook points

* updating app-status for app-store app deployed with gitops

* added AppId field in InstalledAppAndEnvDetails struct

* added update app status hook in fetch resource tree function

* wip

* unstable wire

* sending app_status for overview page via other env api

* fix

* added delete with appid and envid
api's

* deleted active column from db

* fix

* query fix

* query fix

* fix

* update hook added

* fix

* fix

* wire

* wire hyperion

* query output error fix

* delete api fix

* delete api fix for installed apps

* open api helm-app struct updated

* delete query change

* sql up script

* port fix

* delete hook code updated

* unit test skeleton added for repo layer

* cleaned unused code

* unit tests WIP

* unit tests(service layer) done for update api

* unit tests(service layer) done for Delete api

* fix

* mocks

* Integration tests WIP

* integration tests for update method

* integration tests for delete method

* integration tests for delete_with_appid method

* integration tests for delete_with_envid method

* fix

* restructuring

* renaming script number

* minor code restructuring

* refactor tests

* skip tests stmnts added

* added filter support on app_status

* script number changed

* fix

* query fix

* wip

* storing suspended status as hibernating

* app-status filtering for installed apps

* update app-status on appStatus_update_topic nats event

* updated sql script number

* wire

* port fix

* fix

* code review changes

* sql down script

* removed code duplication

* improved logging

* code review changes

* optimised query

* query fix

* removed commented code

* changed error log to warn log

* updated sql script number

* fix: ingress url missing (#2915)

* hotfix ingress url for get resource

* fix cluster id in get resource request

* task: added api for getting default template values (#2905)

* added api for getting default template values

* refactoring

* updated spec

* feat: argo stack upgrade (#2597)

* updated libraries

* temp change: reverted go version

* argocd assets

* updated go version for full mode Dockerfile

* updated argo cd chart and server version

* updated argo workflow image and removed pns executor from workflow-controller cm

* updated argo wf controller executor image

* updated wf controller and executor image

* updated devtron-bom.yaml

* added wf controller image config in devtron-bom.yaml

* reverted change in workflow.yaml

* updated argo wf controller crds

* wip

* updated workflow controller crds

* wip - updated image

* reverted image change

* added argocd assets

* wip

* image changes

* updated installation script

* reverted argo image changes

* reverted argo image changes - part 2

* reverted rollout image

---------

Co-authored-by: Shubham Kumar <87755583+Shubham9t9@users.noreply.github.com>
Co-authored-by: Shubham9t9 <shubhamkumar47022@gmai.com>
Co-authored-by: AJAY KUMAR <99399155+ajaydevtron@users.noreply.github.com>
Co-authored-by: Ajay Kumar <ajaykumar@Ajays-MacBook-Pro.local>
Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com>
Co-authored-by: pawan-mehta-dt <117346502+pawan-mehta-dt@users.noreply.github.com>
Co-authored-by: Gireesh Naidu <111440205+gireesh-devtron@users.noreply.github.com>
Co-authored-by: Vikram <73224103+vikramdevtron@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

Assignees

@gireesh-naidu gireesh-naidu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: App status in app list
2 participants
@gireesh-naidu @kripanshdevtron