Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task: added api for getting default template values #2905

Merged
merged 4 commits into from
Feb 1, 2023
Merged

task: added api for getting default template values #2905

merged 4 commits into from
Feb 1, 2023

Conversation

kartik-579
Copy link
Member

@kartik-579 kartik-579 commented Jan 27, 2023 •
edited
Loading

Description

Expose api for getting default values of a chart version.

Fixes #2916

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested for default values with override
  • tested for default values with updated template

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@gitguardian
Copy link

gitguardian bot commented Jan 31, 2023 •
edited
Loading

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
141558 Generic High Entropy Secret 152411a scripts/devtron-reference-helm-charts/deployment-chart_1-1-0/env-values.yaml View secret
141558 Generic High Entropy Secret 152411a scripts/devtron-reference-helm-charts/reference-chart_4-17-0/env-values.yaml View secret
2763127 Generic High Entropy Secret 152411a scripts/devtron-reference-helm-charts/deployment-chart_1-1-0/secrets-test-values.yaml View secret
2763127 Generic High Entropy Secret 152411a scripts/devtron-reference-helm-charts/reference-chart_4-17-0/secrets-test-values.yaml View secret
5236769 Generic High Entropy Secret 152411a scripts/devtron-reference-helm-charts/deployment-chart_1-1-0/test-values.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@kartik-579 kartik-579 changed the title added api for getting default template values task: added api for getting default template values Feb 1, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kartik-579 kartik-579 merged commit 650a63a into main Feb 1, 2023
@kartik-579 kartik-579 deleted the deployment-template-api branch February 1, 2023 11:15
kartik-579 added a commit that referenced this pull request Mar 28, 2023
@kartik-579 @Shubham9t9
@ajaydevtron @prakarsh-dt @pawan-mehta-dt @gireesh-naidu @vikramdevtron
Oss sync argo upgrade (#7)
c21ddb8 
* docs: Updated README.md file for Devtron chart (#2887)

* Updated README.md file for DEvtron chart

* incorporated changes mentioned in comments

* minor spelling correction

---------

Co-authored-by: Shubham9t9 <shubhamkumar47022@gmai.com>

* removed command to install a particular version of Devtron (#2888)

Co-authored-by: Shubham9t9 <shubhamkumar47022@gmai.com>

* feat: Support of reuse container image in containers section in reference chart 4-17 (#2675)

* support of reuse conatiner image in containers section

* support of reuse container image in latest deployment and rollout chart

* added the readme

---------

Co-authored-by: Ajay Kumar <ajaykumar@Ajays-MacBook-Pro.local>

* release: PR for v0.6.11 (#2866)

* Created release-notes files

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated release notes

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated latest image of dashboard in installer

* Updated release notes

* Updated latest image of devtron in installer

* Updated latest image of dashboard in installer

* Updated latest image of hyperion in installer

* Updated latest image of dashboard in installer

* Updated release notes

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated release notes

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated latest image of ci-runner in installer

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated release notes

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated release notes

* Updated release notes

* Updated latest image of hyperion in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of hyperion in installer

* Update release.txt

* Updated latest image of git-sensor in installer

* Updated latest image of kubewatch in installer

* Updated latest image of image-scanner in installer

* Updated latest image of git-sensor in installer

* Updated latest image of ci-runner in installer

* Updated latest image of lens in installer

* Updated nats image in devtron latest release

* Update installation-script

* Updated latest image of devtron in installer

* Updated latest image of kubelink in installer

* Updated latest image of dashboard in installer

* Update values.yaml

* Updated latest image of hyperion in installer

* Updated release-notes files

* Update releasenotes.md

---------

Co-authored-by: pawan-mehta-dt <117346502+pawan-mehta-dt@users.noreply.github.com>

* feat: Showing app status on app listing page (#2799)

* wip

* rest-handler commit

* constructors added

* test commit

* minor design change and resthandler dev

* getting app_name and env_name in repo layer
for rbac optimisation

* rabc checks moved to service layer for optimisation

* rbac checks in batch

* getting env_identifier instead of env name

* delete and update methods completed in repo layer

* updating app-status for applisting and cdhandler hook points

* updating app-status for app-store app deployed with gitops

* added AppId field in InstalledAppAndEnvDetails struct

* added update app status hook in fetch resource tree function

* wip

* unstable wire

* sending app_status for overview page via other env api

* fix

* added delete with appid and envid
api's

* deleted active column from db

* fix

* query fix

* query fix

* fix

* update hook added

* fix

* fix

* wire

* wire hyperion

* query output error fix

* delete api fix

* delete api fix for installed apps

* open api helm-app struct updated

* delete query change

* sql up script

* port fix

* delete hook code updated

* unit test skeleton added for repo layer

* cleaned unused code

* unit tests WIP

* unit tests(service layer) done for update api

* unit tests(service layer) done for Delete api

* fix

* mocks

* Integration tests WIP

* integration tests for update method

* integration tests for delete method

* integration tests for delete_with_appid method

* integration tests for delete_with_envid method

* fix

* restructuring

* renaming script number

* minor code restructuring

* refactor tests

* skip tests stmnts added

* added filter support on app_status

* script number changed

* fix

* query fix

* wip

* storing suspended status as hibernating

* app-status filtering for installed apps

* update app-status on appStatus_update_topic nats event

* updated sql script number

* wire

* port fix

* fix

* code review changes

* sql down script

* removed code duplication

* improved logging

* code review changes

* optimised query

* query fix

* removed commented code

* changed error log to warn log

* updated sql script number

* fix: ingress url missing (#2915)

* hotfix ingress url for get resource

* fix cluster id in get resource request

* task: added api for getting default template values (#2905)

* added api for getting default template values

* refactoring

* updated spec

* feat: argo stack upgrade (#2597)

* updated libraries

* temp change: reverted go version

* argocd assets

* updated go version for full mode Dockerfile

* updated argo cd chart and server version

* updated argo workflow image and removed pns executor from workflow-controller cm

* updated argo wf controller executor image

* updated wf controller and executor image

* updated devtron-bom.yaml

* added wf controller image config in devtron-bom.yaml

* reverted change in workflow.yaml

* updated argo wf controller crds

* wip

* updated workflow controller crds

* wip - updated image

* reverted image change

* added argocd assets

* wip

* image changes

* updated installation script

* reverted argo image changes

* reverted argo image changes - part 2

* reverted rollout image

---------

Co-authored-by: Shubham Kumar <87755583+Shubham9t9@users.noreply.github.com>
Co-authored-by: Shubham9t9 <shubhamkumar47022@gmai.com>
Co-authored-by: AJAY KUMAR <99399155+ajaydevtron@users.noreply.github.com>
Co-authored-by: Ajay Kumar <ajaykumar@Ajays-MacBook-Pro.local>
Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com>
Co-authored-by: pawan-mehta-dt <117346502+pawan-mehta-dt@users.noreply.github.com>
Co-authored-by: Gireesh Naidu <111440205+gireesh-devtron@users.noreply.github.com>
Co-authored-by: Vikram <73224103+vikramdevtron@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Deployment template diff for default values
2 participants
@kartik-579 @kripanshdevtron