Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: helm deploy hibernate fix #2983

Merged
merged 10 commits into from
Feb 18, 2023
Merged

Conversation

kripanshdevtron
Copy link
Contributor

Description

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@kripanshdevtron kripanshdevtron changed the title Helm deploy hibernate fix fix: Helm deploy hibernate fix Feb 18, 2023
@kripanshdevtron kripanshdevtron changed the title fix: Helm deploy hibernate fix fix: helm deploy hibernate fix Feb 18, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
1.2% 1.2% Duplication

@kripanshdevtron kripanshdevtron marked this pull request as ready for review February 18, 2023 06:05
@kripanshdevtron kripanshdevtron merged commit 2a564ee into main Feb 18, 2023
@kripanshdevtron kripanshdevtron deleted the helm-deploy-hibernate-fix branch February 18, 2023 06:09
vishal-dt added a commit that referenced this pull request Feb 20, 2023
* add api to force delete all cd pipelines of all apps of an environment from argo cd

* update deployment_app_type to helm and toggle deployment_app_created to false in db when changing cd app type and refactored

* remove code smell

* add check on app health status before deleting app from argocd

* resolve build issues

* Revert "resolve build issues"

This reverts commit 647fab2.

* revert and resolve build issues: missing argocd assets

* add support for changing deployment type from helm to argo_cd

* resolve sonar issue: decrease cognitive complexity

* resolve sonar issue: decrease cognitive complexity

* resolve sonar issue: decrease cognitive complexity

* resolve sonar issue: decrease cognitive complexity

* resolve sonar issue: decrease cognitive complexity

* resolve sonar issue: decrease cognitive complexity

* fix: helm deploy hibernate fix (#2983)

* finished on time update fix

* hibernate handling for helm apps

* HPA support for Helm deploy

* bulk API hibernate and unhibernate in helm deployment

* bulk deploy for helm type + hibernate support for custom chart

* scaling bug fixes

* refactoring done

* autoscaling handling for deployment as well

* removed dead code

* dead code removed

* fix: added deployment app type support for app create api, separated cron time for helm app status update (#2995)

* wip

* updated spec

* Feat deployment app type change api (#2998)

* add api spec

* add exclusion list in request body and refactored code

* fixed failedPipelines empty list issue and handled case for missing status rows in db

* fixed pg query issue

* handled argocd app progressing app status

* add exclude apps property in api spec

---------

Co-authored-by: kripanshdevtron <107392309+kripanshdevtron@users.noreply.github.com>
Co-authored-by: kartik-579 <84493919+kartik-579@users.noreply.github.com>
vishal-dt added a commit that referenced this pull request Feb 20, 2023
* add api to force delete all cd pipelines of all apps of an environment from argo cd

* update deployment_app_type to helm and toggle deployment_app_created to false in db when changing cd app type and refactored

* remove code smell

* add check on app health status before deleting app from argocd

* resolve build issues

* Revert "resolve build issues"

This reverts commit 647fab2.

* revert and resolve build issues: missing argocd assets

* add support for changing deployment type from helm to argo_cd

* resolve sonar issue: decrease cognitive complexity

* resolve sonar issue: decrease cognitive complexity

* resolve sonar issue: decrease cognitive complexity

* resolve sonar issue: decrease cognitive complexity

* resolve sonar issue: decrease cognitive complexity

* resolve sonar issue: decrease cognitive complexity

* add api spec

* add exclusion list in request body and refactored code

* fixed failedPipelines empty list issue and handled case for missing status rows in db

* fixed pg query issue

* handled argocd app progressing app status

* add exclude apps property in api spec

* fix: helm deploy hibernate fix (#2983)

* finished on time update fix

* hibernate handling for helm apps

* HPA support for Helm deploy

* bulk API hibernate and unhibernate in helm deployment

* bulk deploy for helm type + hibernate support for custom chart

* scaling bug fixes

* refactoring done

* autoscaling handling for deployment as well

* removed dead code

* dead code removed

* fix: added deployment app type support for app create api, separated cron time for helm app status update (#2995)

* wip

* updated spec

* register app in acd when migrating from helm to argocd

* updated PipelineRepository mock

* add bulk cd pipeline async trigger

---------

Co-authored-by: kripanshdevtron <107392309+kripanshdevtron@users.noreply.github.com>
Co-authored-by: kartik-579 <84493919+kartik-579@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants