fix: added deployment app type support for app create api, separated cron time for helm app status update #2995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
kripanshdevtron
approved these changes
Feb 20, 2023
vishal-dt
added a commit
that referenced
this pull request
Feb 20, 2023
* add api to force delete all cd pipelines of all apps of an environment from argo cd * update deployment_app_type to helm and toggle deployment_app_created to false in db when changing cd app type and refactored * remove code smell * add check on app health status before deleting app from argocd * resolve build issues * Revert "resolve build issues" This reverts commit 647fab2. * revert and resolve build issues: missing argocd assets * add support for changing deployment type from helm to argo_cd * resolve sonar issue: decrease cognitive complexity * resolve sonar issue: decrease cognitive complexity * resolve sonar issue: decrease cognitive complexity * resolve sonar issue: decrease cognitive complexity * resolve sonar issue: decrease cognitive complexity * resolve sonar issue: decrease cognitive complexity * fix: helm deploy hibernate fix (#2983) * finished on time update fix * hibernate handling for helm apps * HPA support for Helm deploy * bulk API hibernate and unhibernate in helm deployment * bulk deploy for helm type + hibernate support for custom chart * scaling bug fixes * refactoring done * autoscaling handling for deployment as well * removed dead code * dead code removed * fix: added deployment app type support for app create api, separated cron time for helm app status update (#2995) * wip * updated spec * Feat deployment app type change api (#2998) * add api spec * add exclusion list in request body and refactored code * fixed failedPipelines empty list issue and handled case for missing status rows in db * fixed pg query issue * handled argocd app progressing app status * add exclude apps property in api spec --------- Co-authored-by: kripanshdevtron <107392309+kripanshdevtron@users.noreply.github.com> Co-authored-by: kartik-579 <84493919+kartik-579@users.noreply.github.com>
vishal-dt
added a commit
that referenced
this pull request
Feb 20, 2023
* add api to force delete all cd pipelines of all apps of an environment from argo cd * update deployment_app_type to helm and toggle deployment_app_created to false in db when changing cd app type and refactored * remove code smell * add check on app health status before deleting app from argocd * resolve build issues * Revert "resolve build issues" This reverts commit 647fab2. * revert and resolve build issues: missing argocd assets * add support for changing deployment type from helm to argo_cd * resolve sonar issue: decrease cognitive complexity * resolve sonar issue: decrease cognitive complexity * resolve sonar issue: decrease cognitive complexity * resolve sonar issue: decrease cognitive complexity * resolve sonar issue: decrease cognitive complexity * resolve sonar issue: decrease cognitive complexity * add api spec * add exclusion list in request body and refactored code * fixed failedPipelines empty list issue and handled case for missing status rows in db * fixed pg query issue * handled argocd app progressing app status * add exclude apps property in api spec * fix: helm deploy hibernate fix (#2983) * finished on time update fix * hibernate handling for helm apps * HPA support for Helm deploy * bulk API hibernate and unhibernate in helm deployment * bulk deploy for helm type + hibernate support for custom chart * scaling bug fixes * refactoring done * autoscaling handling for deployment as well * removed dead code * dead code removed * fix: added deployment app type support for app create api, separated cron time for helm app status update (#2995) * wip * updated spec * register app in acd when migrating from helm to argocd * updated PipelineRepository mock * add bulk cd pipeline async trigger --------- Co-authored-by: kripanshdevtron <107392309+kripanshdevtron@users.noreply.github.com> Co-authored-by: kartik-579 <84493919+kartik-579@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for deployment app type configuration support in app create api and separated cron time for helm pipeline from acd pipeline status fetch.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?