Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: acd app delete non cascade #3506

Merged
merged 37 commits into from
Jun 20, 2023
Merged

fix: acd app delete non cascade #3506

merged 37 commits into from
Jun 20, 2023

Conversation

Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented Jun 13, 2023

Duplicate of #3339

Ash-exp added 30 commits May 3, 2023 17:01
@Ash-exp
acd app delete with non-cascade
a6a2990
@Ash-exp
Merge branch 'main' into fix-acd-app-delete-non-cascade
9c48fa2
@Ash-exp
handled DeleteErrorResponse length error
b468fcd
@Ash-exp
added go routine
035d07f
@Ash-exp
argo non-casecade delete for helm and devtron app
d5ee71d
@Ash-exp
Merge branch 'main' into fix-acd-app-delete-non-cascade
63d1beb
@Ash-exp
fix: api response for cluster connection error
d8d7d1d
@Ash-exp
fix: nil pointer for cluster details
0953fd5
@Ash-exp
fix: updated test interface for pipeline
76ac352
@Ash-exp
fix: non-cascade delete condition
7a32609
@Ash-exp
fix: forceDelete and cascadeDelete validation
6a96d02
@Ash-exp
fix: delete response for force delete req
012793e
@Ash-exp
fix: added clusterName to res
466b6ed
@Ash-exp
fix: added clusterName to cluster-conn api resp
7f0cdfe
@Ash-exp
fix: updated non-cascade api resp
8bf60e9
@Ash-exp
fix: updated non-cascade api err return
4c18f85
@Ash-exp
fix: updated chart list delete bug
2a734f3
@Ash-exp
fix: installed app delete bug
4bb7fbb
@Ash-exp
fix: installed app noncascade delete bug
dbfbe7a
@Ash-exp
Merge branch 'main' into fix-acd-app-delete-non-cascade
ff8ae2e
@Ash-exp
Merge branch 'main' into fix-acd-app-delete-non-cascade
ac51204
@Ash-exp
fix: helm release force delete
b477319
@Ash-exp
fix: appstore release force delete
98c3ae4
@Ash-exp
fix: appstore deployment list response
d2cb16a
@Ash-exp
fix: bulk delete deployment api condition
78f1421
@Ash-exp
Merge branch 'main' into fix-acd-app-delete-non-cascade
125989e
@Ash-exp
Merge branch 'main' into fix-acd-app-delete-non-cascade
11fd73c
@Ash-exp
fixed typo and response message
e8d5244
@Ash-exp
Merge branch 'main' into fix-acd-app-delete-non-cascade
c7690c1
@Ash-exp
fix: bulk delete cd pipeline api payload
87bfaf7
@Ash-exp Ash-exp requested a review from iamayushm June 13, 2023 11:42
@gitguardian
Copy link

gitguardian bot commented Jun 13, 2023 •
edited
Loading

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
141558 Generic High Entropy Secret ac51204 scripts/devtron-reference-helm-charts/statefulset-chart_4-18-0/env-values.yaml View secret
141558 Generic High Entropy Secret ac51204 scripts/devtron-reference-helm-charts/statefulset-chart_4-18-0/env-values.yaml View secret
2763127 Generic High Entropy Secret ac51204 scripts/devtron-reference-helm-charts/statefulset-chart_4-18-0/secrets-test-values.yaml View secret
2763127 Generic High Entropy Secret ac51204 scripts/devtron-reference-helm-charts/statefulset-chart_4-18-0/secrets-test-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@Ash-exp Ash-exp self-assigned this Jun 13, 2023
@Ash-exp Ash-exp added the duplicate This issue or pull request already exists label Jun 13, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

No Coverage information No Coverage information
16.1% 16.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Ash-exp Ash-exp requested a review from vikramdevtron June 19, 2023 13:45
@Ash-exp Ash-exp merged commit 9690c95 into main Jun 20, 2023
@Ash-exp Ash-exp deleted the fix-acd-app-delete-non-cascade branch June 20, 2023 12:19
gireesh-naidu pushed a commit that referenced this pull request Jun 26, 2023
@kartik-579 @Ash-exp @Juneezee
Oss sync (#266)
fc7d39a 
* fix: acd app delete non cascade (#3506)

* acd app delete with non-cascade

* handled DeleteErrorResponse length error

* added go routine

* argo non-casecade delete for helm and devtron app

* fix: api response for cluster connection error

* fix: nil pointer for cluster details

* fix: updated test interface for pipeline

* fix: non-cascade delete condition

* fix: forceDelete and cascadeDelete validation

* fix: delete response for force delete req

* fix: added clusterName to res

* fix: added clusterName to cluster-conn api resp

* fix: updated non-cascade api resp

* fix: updated non-cascade api err return

* fix: updated chart list delete bug

* fix: installed app delete bug

* fix: installed app noncascade delete bug

* fix: helm release force delete

* fix: appstore release force delete

* fix: appstore deployment list response

* fix: bulk delete deployment api condition

* fixed typo and response message

* fix: bulk delete cd pipeline api payload

* fix: logger and conditional chain

* updated wire

* modifed cluster services

* chore: replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml` (#3355)

At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>

---------

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Co-authored-by: Asutosh Das <asutosh2000ad@gmail.com>
Co-authored-by: Eng Zer Jun <engzerjun@gmail.com>
gireesh-naidu pushed a commit that referenced this pull request Jun 26, 2023
@kartik-579 @Ash-exp
@Juneezee @prakarsh-dt @pawan-mehta-dt
Oss sync (#269)
e1bc9f1 
* fix: acd app delete non cascade (#3506)

* acd app delete with non-cascade

* handled DeleteErrorResponse length error

* added go routine

* argo non-casecade delete for helm and devtron app

* fix: api response for cluster connection error

* fix: nil pointer for cluster details

* fix: updated test interface for pipeline

* fix: non-cascade delete condition

* fix: forceDelete and cascadeDelete validation

* fix: delete response for force delete req

* fix: added clusterName to res

* fix: added clusterName to cluster-conn api resp

* fix: updated non-cascade api resp

* fix: updated non-cascade api err return

* fix: updated chart list delete bug

* fix: installed app delete bug

* fix: installed app noncascade delete bug

* fix: helm release force delete

* fix: appstore release force delete

* fix: appstore deployment list response

* fix: bulk delete deployment api condition

* fixed typo and response message

* fix: bulk delete cd pipeline api payload

* fix: logger and conditional chain

* updated wire

* modifed cluster services

* chore: replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml` (#3355)

At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>

* release: PR for v0.6.18-rc.2 (#3510)

* Created release-notes files

* Updated release notes

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated latest image of dashboard in installer

* Updated release notes

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated latest image of dashboard in installer

* Updated latest image of dashboard in installer

* Updated latest image of dashboard in installer

* Updated latest image of dashboard in installer

* Updated latest image of dashboard in installer

* Updated release-notes files

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated latest image of ci-runner in installer

* Updated latest image of kubelink in installer

* Updated latest image of dashboard in installer

* Updated latest image of dashboard in installer

* Updated release-notes files

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated latest image of dashboard in installer

* Updated release-notes files

* Updated latest image of dashboard in installer

* Updated release-notes files

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated latest image of dashboard in installer

* Updated latest image of ci-runner in installer

* Updated latest image of dashboard in installer

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated latest image of dashboard in installer

* Updated release-notes files

* Update devtron-installer.yaml

* Update installation-script

* Update values.yaml

* Update devtron-bom.yaml

* Update Chart.yaml

* Update devtron-bom.yaml

* Update values.yaml

* Update releasenotes.md

* Updated release-notes files

---------

Co-authored-by: Pawan Mehta <117346502+pawan-mehta-dt@users.noreply.github.com>

* task: updated workflow name provision in app workflow api (#3526)

* updated workflow name provision in app workflow api

* review comment

---------

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Co-authored-by: Asutosh Das <asutosh2000ad@gmail.com>
Co-authored-by: Eng Zer Jun <engzerjun@gmail.com>
Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com>
Co-authored-by: Pawan Mehta <117346502+pawan-mehta-dt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamayushm iamayushm iamayushm approved these changes

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

Assignees

@Ash-exp Ash-exp

Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ash-exp @iamayushm