task: updated workflow name provision in app workflow api #3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartik-579
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
2 tasks
vikramdevtron
approved these changes
Jun 21, 2023
gireesh-naidu
pushed a commit
that referenced
this pull request
Jun 26, 2023
* fix: acd app delete non cascade (#3506) * acd app delete with non-cascade * handled DeleteErrorResponse length error * added go routine * argo non-casecade delete for helm and devtron app * fix: api response for cluster connection error * fix: nil pointer for cluster details * fix: updated test interface for pipeline * fix: non-cascade delete condition * fix: forceDelete and cascadeDelete validation * fix: delete response for force delete req * fix: added clusterName to res * fix: added clusterName to cluster-conn api resp * fix: updated non-cascade api resp * fix: updated non-cascade api err return * fix: updated chart list delete bug * fix: installed app delete bug * fix: installed app noncascade delete bug * fix: helm release force delete * fix: appstore release force delete * fix: appstore deployment list response * fix: bulk delete deployment api condition * fixed typo and response message * fix: bulk delete cd pipeline api payload * fix: logger and conditional chain * updated wire * modifed cluster services * chore: replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml` (#3355) At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> * release: PR for v0.6.18-rc.2 (#3510) * Created release-notes files * Updated release notes * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated latest image of dashboard in installer * Updated release notes * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated latest image of dashboard in installer * Updated latest image of dashboard in installer * Updated latest image of dashboard in installer * Updated latest image of dashboard in installer * Updated latest image of dashboard in installer * Updated release-notes files * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated latest image of ci-runner in installer * Updated latest image of kubelink in installer * Updated latest image of dashboard in installer * Updated latest image of dashboard in installer * Updated release-notes files * Updated latest image of devtron in installer * Updated latest image of hyperion in installer * Updated latest image of dashboard in installer * Updated release-notes files * Updated latest image of dashboard in installer * Updated release-notes files * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated latest image of dashboard in installer * Updated latest image of ci-runner in installer * Updated latest image of dashboard in installer * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated latest image of dashboard in installer * Updated release-notes files * Update devtron-installer.yaml * Update installation-script * Update values.yaml * Update devtron-bom.yaml * Update Chart.yaml * Update devtron-bom.yaml * Update values.yaml * Update releasenotes.md * Updated release-notes files --------- Co-authored-by: Pawan Mehta <117346502+pawan-mehta-dt@users.noreply.github.com> * task: updated workflow name provision in app workflow api (#3526) * updated workflow name provision in app workflow api * review comment --------- Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Asutosh Das <asutosh2000ad@gmail.com> Co-authored-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com> Co-authored-by: Pawan Mehta <117346502+pawan-mehta-dt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduced an optional query param
workflowNamefor getting specific workflow detail in an app. If not provided workflow will be fetched using appId only.Fixes #3534
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?