Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permalink for methods ending with a question mark not working #44

Closed
bytesource opened this issue Apr 13, 2012 · 3 comments
Closed

Permalink for methods ending with a question mark not working #44

bytesource opened this issue Apr 13, 2012 · 3 comments

Comments

@bytesource
Copy link

Hi Loren,

It seems that permalinks for methods ending with a question mark are not working. For example, clicking on the permalink link of the is_boolean? method returns a 404 not found error:
http://rubydoc.info/github/bytesource/with_validations/master/WithValidations:is_boolean%3F

Best regards,

Stefan
@zapnap
Copy link
Collaborator

zapnap commented Aug 20, 2014

Apologies for the lack of response on this -- just cleaning up some issues now. It should have been fixed long ago :). Thanks for reporting it!

@zapnap zapnap closed this as completed Aug 20, 2014
@jonathanhefner
Copy link

This appears to still be an issue, and it's not just limited to methods that end in a question mark. Examples:

It looks like there might be some double-escaping happening with permalink urls.

@lsegal
Copy link
Collaborator

lsegal commented Aug 8, 2016 •
edited
Loading

It's not really double escaping so much as it is a discrepancy between urlencoding on the link generation side vs. the url decoding on the path routing side. It seems that the request.path_info data that YARD gets is not as aggressively decoded, so YARD is getting "%5B" in the path when it should be seeing a "[". Not sure why that is happening, but I've updated the way YARD urlencodes which should provide nicer URLs and fix this problem.

Thanks for reporting! This should be out with the next YARD release (sometime this week)

lsegal added a commit to lsegal/yard that referenced this issue Aug 8, 2016
@lsegal
Use a more conservative urlencode algorithm
77844ff 
Percent encodes fewer reserved characters, since these are never
considered special characters in the context of generated YARD URLs.

References docmeta/rubydoc.info#44
lsegal added a commit to lsegal/yard that referenced this issue Jan 7, 2017
@lsegal
Tag release v0.9.6
f67ed86 
References:
  #1002, #1004, #1005, #1006, #1007, #1008, #1009, #1011,
  #1012, #1016, #1024, #1028, #1033, #1042, #1045, #1047,
  #1049, #1050, #1051, #1052, #799, #948, #995, #997,
  docmeta/rubydoc.info#44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zapnap @lsegal @bytesource @jonathanhefner