Server Process.fork error Windows

[MSP-Greg]

After pulling changes tonite, tests failed on Windows.

Crash on Process.fork. See the following, and note

'If fork is not usable, Process.respond_to?(:fork) returns false.' Hence, added that test to the code.

https://msp-greg.github.io/Ruby-2.3/Core/Process.html#fork-class_method

Completed Tasks

• I have read the Contributing Guide.
• The pull request is complete (implemented / written).
• Git commits have been cleaned up (squash WIP / revert commits).
• Tested locally against Ruby 2.2.4 & 2.3.2.

[coveralls]

Coverage increased (+0.006%) to 93.488% when pulling a570766 on MSP-Greg:server-process.fork into 57ebca0 on lsegal:master.

[lsegal]

Can you explain how this failed (stack trace, etc)? I tested the original code on a Windows 10 machine and it seemed to be working fine; the rescue should catch the exception if one is raised. The respond_to? check is not reliable across Ruby implementations (that doc note only applies to MRI, not JRuby, for example), which is why it was omitted. It can be added, but it should just be a no-op for almost all implementations.

I'd be curious to see how your tests were failing, though.

[lsegal]

Ah, I was able to reproduce. The rescue should have been rescuing Exception instead of a blank rescue call since the error might not be a RuntimeError (NotImplementedError is not one). This makes it so the respond_to? is not needed (and will still handle an implementation that responds to the method but still fails).

[MSP-Greg]

Your commit passes local tests on 2.2.4 & 2.3.2.

Thanks, I saw the mention in the docs and forgot about rescue, and how it works 'a bit different' in Ruby...