Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the case for updated binding redirects #11411

Merged

Conversation

JaynieBai
Copy link
Member

@JaynieBai JaynieBai commented Feb 10, 2025

Fixes #9773

Context
When a project's references are modified in a way that eliminates version conflicts, the existing binding redirects in the exe.config file in bin folder are not automatically removed during the next build. This PR ensures that binding redirects are properly removed when they are no longer needed.

Changes Made
Prevent .exe.config removal from obj folder by incremental clean by changing it's content with the original App.config when RAR returns empty SuggestedBindingRedirects.

Testing
Manual.

@JaynieBai JaynieBai changed the title Dev/jenny/fix binding redirect Handle the case for updated binding redirects Feb 10, 2025
@YuliiaKovalova YuliiaKovalova merged commit def54a6 into dotnet:main Mar 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: removing the reason of bindingRedirect doesn't trigger exe.config file to be regenerated
3 participants