Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the case for updated binding redirects #11411

Merged
merged 6 commits into from
Mar 3, 2025
Merged

Handle the case for updated binding redirects #11411

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b31bdfb
handle the case for updated binding redirects
YuliiaKovalova Nov 20, 2024
5caa998
remove extra spaces
YuliiaKovalova Nov 20, 2024
642732d
Update Microsoft.Common.CurrentVersion.targets
YuliiaKovalova Nov 20, 2024
cc47689
Update src/Tasks/Microsoft.Common.CurrentVersion.targets
YuliiaKovalova Jan 2, 2025
fe4618e
Add '$(DesignTimeBuild)' != 'true'
JaynieBai Feb 10, 2025
d2510d3
Merge branch 'main' into dev/jenny/fix_binding_redirect
JaynieBai Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/Tasks/Microsoft.Common.CurrentVersion.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2568,6 +2568,24 @@ Copyright (C) Microsoft Corporation. All rights reserved.
<AppConfig Condition="$(_NewGenerateBindingRedirectsIntermediateAppConfig) == 'true'">$(_GenerateBindingRedirectsIntermediateAppConfig)</AppConfig>
</PropertyGroup>

<PropertyGroup>
<ConfigFileExists Condition="Exists('@(AppConfigWithTargetPath->'$(OutDir)%(TargetPath)')')">true</ConfigFileExists>
<HasNoBindingRedirects Condition="'@(SuggestedBindingRedirects)' == ''">true</HasNoBindingRedirects>
</PropertyGroup>

<!-- Overwrites .config file with a App.config content if RAR returned empty @(SuggestedBindingRedirects). -->
<Copy
SourceFiles="@(AppConfigWithTargetPath->'%(FullPath)')"
DestinationFiles="$(_GenerateBindingRedirectsIntermediateAppConfig)"
SkipUnchangedFiles="true"
Condition="'$(ConfigFileExists)' == 'true' and '$(HasNoBindingRedirects)' == 'true' and '$(DesignTimeBuild)' != 'true'">
<Output TaskParameter="CopiedFiles" ItemName="FileWrites"/>
</Copy>
<Touch
Files="$(_GenerateBindingRedirectsIntermediateAppConfig)"
AlwaysCreate="true"
Condition="'$(ConfigFileExists)' == 'true' and '$(HasNoBindingRedirects)' == 'true' and '$(DesignTimeBuild)' != 'true'"/>

<ItemGroup Condition="$(_NewGenerateBindingRedirectsIntermediateAppConfig) == 'true'">
<AppConfigWithTargetPath Remove="@(AppConfigWithTargetPath)" />
<AppConfigWithTargetPath Include="$(AppConfig)">
Expand Down
Loading