Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run wasm console sample on Helix #45768

Merged

Conversation

MaximLipnin
Copy link
Contributor

@MaximLipnin MaximLipnin commented Dec 8, 2020

  • Included the WASM console sample project to the library test build. The sample can still be built/run locally using make file.
  • Added zipping/copying the sample application to helix directory from where it can be consumed by CI.
  • To run on Helix, tried to use a simple helix work item which wouldn't rely on generated RunTests.sh and just call the xharness command directly.

Relates to #43865

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@MaximLipnin MaximLipnin force-pushed the run_wasm_console_sample_on_helix branch from 14aef9d to 12590c8 Compare December 8, 2020 17:05
@MaximLipnin MaximLipnin force-pushed the run_wasm_console_sample_on_helix branch 3 times, most recently from 87bfb37 to 6e81506 Compare December 14, 2020 13:20
@radical radical added the arch-wasm WebAssembly architecture label Dec 14, 2020
@MaximLipnin MaximLipnin force-pushed the run_wasm_console_sample_on_helix branch from d92d6d6 to a897d2c Compare December 15, 2020 09:25
@MaximLipnin MaximLipnin force-pushed the run_wasm_console_sample_on_helix branch from a5709f3 to 10540ee Compare December 15, 2020 15:13
@radical
Copy link
Member

radical commented Dec 16, 2020

@MaximLipnin does the sample run on helix now? Can you share a link to the log? I wasn't able to get to it.

Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akoeplinger would be able to review this well. I don't know enough about the helix related bits.

  • I'm wondering if we can/should be generating RunTests.sh.
  • We could make this handle more samples, or similar projects too, but that doesn't have to be in this PR.
  • In general, this looks fine, and it seems to work!
  • It should be useful to get this in anyway, as it will prevent samples getting unintentionally broken.

@akoeplinger
Copy link
Member

I'm wondering if we can/should be generating RunTests.sh

That is only done by the libraries tests afaik.

@akoeplinger akoeplinger merged commit 78efb92 into dotnet:master Dec 16, 2020
@MaximLipnin MaximLipnin deleted the run_wasm_console_sample_on_helix branch December 16, 2020 10:13
@safern
Copy link
Member

safern commented Dec 16, 2020

That is only done by the libraries tests afaik.

This is done here. You could technically import these targets for the sample project and just hook them up:

<UsingTask TaskName="GenerateRunScript" AssemblyFile="$(InstallerTasksAssemblyPath)"/>
<Target Name="GenerateRunScript">

I think I would rather do that and try to be consistent, it seems cumbersome to have that "workaround" in sendhelix to include the sample as part of the payload and hardcode the HelixCommand.

Can we open a follow up issue to clean this up and make it more generic for more samples? I see we also added this for iOS and it is doing somewhat similar instead of use the targets we already have.

MaximLipnin added a commit that referenced this pull request Dec 18, 2020
This is a continuation of #45768 for the browser sample.  
Which sample to run depends on the Helix scenario:  
- the console sample runs under normal scenario;
- the browser sample runs under WasmTestOnBrowser scenario.

Relates to #43865
@ghost ghost locked as resolved and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants