-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Wasm browser sample on Helix #46144
Run Wasm browser sample on Helix #46144
Conversation
0a6618f
to
03fb511
Compare
There are a few things to note here:
I implemented (2) in c9dccc0 . |
- Add a `--testing` argument, in presence of which the index.html emits the a test exit code that can be picked up by xharness - Also, catch loading errors, and exit the test for those too
38dd7e9
to
767af99
Compare
Rebased the latest master to pick up Steve's AOT changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but yeah ideally we'd have a similar functionality in xharness like we do for iOS/Android where we pass the --expected-exit-code instead of expecting an xunit test run+result. But that can be cleaned up later :)
This is a continuation of #45768 for the browser sample.
Which sample to run depends on the Helix scenario:
normal
scenario;WasmTestOnBrowser
scenario.Relates to #43865