[Cases] Fix missing displayName for some react components #123460
Merged
+65
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
academo
added
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
academo
added
backport:skip
jonathan-buttner
approved these changes
Jan 20, 2022
cnasikas
approved these changes
Jan 20, 2022
💛 Build succeeded, but was flaky
Test FailuresMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
First part of #123375
This PR will fix most[1] of the existing components missing a displayName using the
ignoreTranspilerNameof thereact/display-namelinting rule.[1] most because there are inlined components where a longer refactor is required to set a displayName. e.g.:
in this case the react component is an anonymous function and enabling
ignoreTranspilerNamewill make this file fail but it is harder to auto-fix.All these files were "auto-fixed" using a custom fixing script. https://gist.github.com/academo/f2bc72d733e6fe1d5960b3b9b37247ae (no fingers were exhausted typing all these changes by hand)