[Cases] Add eslintrule to enforce display names and ignore existing problems #123692
+671
−624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
academo
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
peteharverson
changed the title
cnasikas
approved these changes
Jan 25, 2022
| @@ -1070,6 +1070,12 @@ module.exports = { | |||
| '@typescript-eslint/no-duplicate-imports': ['error'], | |||
| }, | |||
| }, | |||
| { | |||
| files: ['x-pack/plugins/cases/public/**/*.{js,mjs,ts,tsx}'], | |||
There was a problem hiding this comment.
How do you feel about ignoring test files? I think we could add this: https://eslint.org/docs/user-guide/configuring/ignoring-code#ignorepatterns-in-config-files
There was a problem hiding this comment.
@jonathan-buttner I excluded test files and removed the changes from them.
added 2 commits
January 26, 2022 16:03
jonathan-buttner
approved these changes
Jan 26, 2022
|
@elasticmachine merge upstream0 |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a follow up to #123460
in short:
react/display-namewithignoreTranspilerNameon all cases plugin files inside the public folderNote: Better to see this PR disabling whitespaces in github. No business logic was changed in this PR, only adding comments and running
eslint --fixon top which changed indentation.All these eslint ignores were added with https://github.com/amanda-mitchell/suppress-eslint-errors