Automatically generate bindings + upgrade to v1.0.0 #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, I think I tracked down the source of the Linux failures. The problem was the |
Merged
Automatically generate bindings at build time for the target. This means the maintainers do not need to be regenerated on three separate platforms whenever librdkafka is bumped, which is particularly nice considering that FreeBSD machines are not easily available to the maintainers. The downside is that users are required to have libclang installed at build time in order to run bindgen.
The --enable-static flag is a bit of a misnomer. It doesn't tell librdkafka to build static libraries; rather, it tells librdkafka to attempt to statically link liblz4, libz, et al. into the *shared* librdkafka. This, unsurprisingly, often goes wrong. Just drop the --enable-static flag. We'll still get a librdkafka.a that we can link against, and we'll let cargo link in liblz4, libz, et al.
v1.0.2 is old enough that it's no longer available from the standard Apache mirrors.
This was referenced Apr 23, 2019
Merged
flavray
approved these changes
Apr 25, 2019
|
Great investigation on the linux build failure :) |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slimmed-down version of #117 that doesn't included unmerged librdkafka patches. Should be ready for review! 🎉