Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operations): Use rdkafka crate from the upstream Git repository #1063

Merged
4 commits merged into from
Oct 24, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 21, 2019

Fixes rdkafka part of #1032.

Although it solves problem with compiling rdkafka crate, there are still linking issues with it unsolved yet.

Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
@ghost ghost mentioned this pull request Oct 21, 2019
@binarylogic binarylogic changed the title Use rdkafka crate from the fork fix(operations): Use rdkafka crate from the fork Oct 21, 2019
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
@ghost
Copy link
Author

ghost commented Oct 23, 2019

The problem with CI is fede1024/rust-rdkafka#126. Newer versions of rust-rdkafka crate require libclang and libllvm. While the requirement might seem as too much, I generally like the reasoning behind switching to generation of bindings during build time implemented in fede1024/rust-rdkafka#119 because it simplifies compilation for new platforms. For example, without it #859 would be much harder to do.

@benesch
Copy link

benesch commented Oct 23, 2019

I just merged a change to rust-rdkafka that removes the build-time dependency on clang/libclang, if you want to give that a try! Details here: fede1024/rust-rdkafka#126 (comment)

Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
@ghost ghost changed the title fix(operations): Use rdkafka crate from the fork fix(operations): Use rdkafka crate from the upstream Git Oct 24, 2019
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
@ghost ghost changed the title fix(operations): Use rdkafka crate from the upstream Git fix(operations): Use rdkafka crate from the upstream Git repository Oct 24, 2019
@ghost ghost merged commit 137e9ea into master Oct 24, 2019
@LucioFranco
Copy link
Contributor

@benesch would it be possible to get a release of this?

@ghost ghost deleted the macos-rdkafka-fork branch November 20, 2019 16:53
@benesch
Copy link

benesch commented Jan 13, 2020

Sorry for the long delay here—but 0.23 is out and incorporates all the build system fixes.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants