-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ramips-mt76x8: Add support for Xiaomi Mi Router 4A (100M International Edition v2 - R4ACv2) - closes #3183 #3414
base: main
Are you sure you want to change the base?
Conversation
Changing the docs as well was missed in b1cdcc8 Reported-in: freifunk-gluon#3414 Reported-by: 132701936+ChristianMiddendorf@users.noreply.github.com
I'll look into this after work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution :)
Assuming the checklist went all well,
I'd suggest the changes above and afterwords squashing the three commits into a clean one with a proper commit message, which would be sth. like
<target-name>: Add support for <vendor-name> <device-name>
and just to avoid the blip: Contrary to the current PR title the vendor is called Xiaomi
.
Aside that this looks fine to me. Have a good night everyone!
Changing the docs as well was missed in b1cdcc8 Reported-in: freifunk-gluon#3414 Reported-by: 132701936+ChristianMiddendorf@users.noreply.github.com Co-authored-by: 132701936+ChristianMiddendorf@users.noreply.github.com
Changing the docs as well was missed in b1cdcc8 Reported-in: freifunk-gluon#3414 Reported-by: @ChristianMiddendorf Co-authored-by: @ChristianMiddendorf
…l Edition v2 - R4ACv2) Co-Authored-By: Jan-Niklas Burfeind <github@aiyionpri.me>
@AiyionPrime please check the PR again, your Request blocks the merge :) |
sysupgrade [-n]
,firstboot
)(
lua -e 'print(require("platform_info").get_image_name())'
)(https://gluon.readthedocs.io/en/latest/dev/hardware.html#hardware-support-in-packages)
factory reset must be performed before checking the primary MAC address, as
the setting from the old version is not reset otherwise.
(https://gluon.readthedocs.io/en/latest/features/configmode.html)
is_outdoor_device
function inpackage/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
is_cellular_device
function inpackage/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
setup_ncm_qmi
topackage/gluon-core/luasrc/lib/gluon/upgrade/250-cellular
docs/user/supported_devices.rst