Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ramips-mt76x8: Add support for Xiaomi Mi Router 4A (100M International Edition v2 - R4ACv2) - closes #3183 #3414

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ChristianMiddendorf
Copy link
Contributor

  • Must be flashable from vendor firmware
    • Web interface
    • TFTP
    • Other: <sysupgrade -n from OpenWRT 24.10rc5>
  • Must support upgrade mechanism
    • Must have working sysupgrade
      • Must keep/forget configuration (sysupgrade [-n], firstboot)
    • Gluon profile name matches autoupdater image name
      (lua -e 'print(require("platform_info").get_image_name())')
  • Reset/WPS/... button must return device into config mode
  • Primary MAC address should match address on device label (or packaging)
    (https://gluon.readthedocs.io/en/latest/dev/hardware.html#hardware-support-in-packages)
    • When re-adding a device that was supported by an earlier version of Gluon, a
      factory reset must be performed before checking the primary MAC address, as
      the setting from the old version is not reset otherwise.
  • Wired network
    • should support all network ports on the device
    • must have correct port assignment (WAN/LAN)
      • if there are multiple ports but no WAN port:
        • the PoE input should be WAN, all other ports LAN
        • otherwise the first port should be declared as WAN, all other ports LAN
  • Wireless network (if applicable)
    • Association with AP must be possible on all radios
    • Association with 802.11s mesh must work on all radios
    • AP+mesh mode must work in parallel on all radios
  • LED mapping
    • Power/system LED
    • Radio LEDs
      • Should map to their respective radio
      • Should show activity
    • Switch port LEDs
      • Should map to their respective port (or switch, if only one led present)
      • Should show link state and activity
  • Outdoor devices only:
    • Added board name to is_outdoor_device function in package/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
  • Cellular devices only:
    • Added board name to is_cellular_device function in package/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
    • Added board name with modem setup function setup_ncm_qmi to package/gluon-core/luasrc/lib/gluon/upgrade/250-cellular
  • Docs:
    • Added Device to docs/user/supported_devices.rst

@github-actions github-actions bot added 3. topic: docs Topic: Documentation 3. topic: hardware Topic: Hardware Support labels Jan 6, 2025
herbetom added a commit to herbetom/gluon that referenced this pull request Jan 15, 2025
Changing the docs as well was missed in b1cdcc8

Reported-in: freifunk-gluon#3414
Reported-by: 132701936+ChristianMiddendorf@users.noreply.github.com
@AiyionPrime
Copy link
Member

I'll look into this after work

Copy link
Member

@AiyionPrime AiyionPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution :)

Assuming the checklist went all well,
I'd suggest the changes above and afterwords squashing the three commits into a clean one with a proper commit message, which would be sth. like
<target-name>: Add support for <vendor-name> <device-name>

and just to avoid the blip: Contrary to the current PR title the vendor is called Xiaomi.

Aside that this looks fine to me. Have a good night everyone!

herbetom added a commit to herbetom/gluon that referenced this pull request Mar 6, 2025
Changing the docs as well was missed in b1cdcc8

Reported-in: freifunk-gluon#3414
Reported-by: 132701936+ChristianMiddendorf@users.noreply.github.com
Co-authored-by: 132701936+ChristianMiddendorf@users.noreply.github.com
@ChristianMiddendorf ChristianMiddendorf changed the title Adding Xiami Mi Router 4A (100M International Edition v2 - R4ACv2 closes #3183 Adding Xiaomi Mi Router 4A (100M International Edition v2 - R4ACv2 closes #3183 Mar 8, 2025
@ChristianMiddendorf ChristianMiddendorf changed the title Adding Xiaomi Mi Router 4A (100M International Edition v2 - R4ACv2 closes #3183 ramips-mt76x8: Add support for Xiaomi Mi Router 4A (100M International Edition v2 - R4ACv2) - closes #3183 Mar 8, 2025
herbetom added a commit to herbetom/gluon that referenced this pull request Mar 10, 2025
Changing the docs as well was missed in b1cdcc8

Reported-in: freifunk-gluon#3414
Reported-by: @ChristianMiddendorf
Co-authored-by: @ChristianMiddendorf
rotanid and others added 2 commits March 10, 2025 22:57
@rotanid
Copy link
Member

rotanid commented Mar 11, 2025

@AiyionPrime please check the PR again, your Request blocks the merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. topic: docs Topic: Documentation 3. topic: hardware Topic: Hardware Support
Projects
None yet
4 participants