Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: user/getting_started: add dependencies #3424

Merged

Conversation

herbetom
Copy link
Contributor

Changing the docs as well was missed in b1cdcc8

Reported-in: #3414
Reported-by: 132701936+ChristianMiddendorf@users.noreply.github.com

@herbetom
Copy link
Contributor Author

@blocktrron
Copy link
Member

Please refer the dockerfile in the documentation instead of duplicating.

I also assume one would rather want a install command he can just copy and paste.

@AiyionPrime
Copy link
Member

Just a general minor gesture, but I'd try to add Christian as author of the commit, if it's his contribution.
Feel free to add yourself as a co-author or the other way around, so that others can infer whose idea this was by looking at the git log :)

This might show a little more appreciation for the work they've put into spotting this.

@herbetom herbetom force-pushed the fixup-toollist-getting_started branch from c0c98ec to fc00984 Compare March 6, 2025 23:28
@herbetom
Copy link
Contributor Author

herbetom commented Mar 6, 2025

I think i added Christian as "Reported-" because i took the idea of fixing that from there but didn't actually use those changes and with the commit message also not beeing what we need i didn't really felt comfortable authoring that in someone elses name. But adding a "Co-Authored-By" seems like a good idea.


Regarding referring to the Dockerfile: I'm not going to look into that further because while it seems like a sensible idea it either would be something without a link (which also isn't that user friendly) or it would probabbly end up pointing to the main branch (at least I can't think of a good way to make the link dynamic) which also would be supoptimal. So in that regard it's a "take it or leave it" regarding my involvement 🙈

Changing the docs as well was missed in b1cdcc8

Reported-in: freifunk-gluon#3414
Reported-by: @ChristianMiddendorf
Co-authored-by: @ChristianMiddendorf
@herbetom herbetom force-pushed the fixup-toollist-getting_started branch from fc00984 to d91f3f3 Compare March 10, 2025 19:54
@rotanid rotanid merged commit ed8de41 into freifunk-gluon:main Mar 10, 2025
10 checks passed
@herbetom herbetom deleted the fixup-toollist-getting_started branch March 10, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. topic: docs Topic: Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants