Skip to content
This repository has been archived by the owner on Jun 2, 2022. It is now read-only.

Turn on -Ywarn-unused:patvars #228

Merged
merged 1 commit into from
Feb 14, 2018
Merged

Conversation

tpolecat
Copy link
Member

This should have been on … I don't remember why I turned it off. Anyway @som-snytt advises that it will prevent the Position.point on NoPosition issue scala/bug#10448 (!)

Copy link
Contributor

@swalker2m swalker2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct to me. 👍

@som-snytt
Copy link

I think I noticed that side-effect last weekend. It will also warn on unused patvars, for which you can use case C(x @ _, y @ _) => syntax to say the name is only for documentation.

@tpolecat tpolecat merged commit c117f2c into gemini-hlsw:master Feb 14, 2018
@tpolecat tpolecat deleted the patvars branch February 14, 2018 17:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants