Turn on -Ywarn-unused:patvars

build.sbt

@@ -142,7 +142,7 @@ lazy val commonSettings = Seq(
     "-Ywarn-unused:imports",             // Warn if an import selector is not referenced.
     "-Ywarn-unused:locals",              // Warn if a local definition is unused.
     "-Ywarn-unused:params",              // Warn if a value parameter is unused.
-    // "-Ywarn-unused:patvars",             // Warn if a variable bound in a pattern is unused.
+    "-Ywarn-unused:patvars",             // Warn if a variable bound in a pattern is unused.
     "-Ywarn-unused:privates",            // Warn if a private member is unused.
     "-Ywarn-value-discard",              // Warn when non-Unit expression results are unused.
     "-Yinduction-heuristics",            // speeds up the compilation of inductive implicit resolution

modules/core/shared/src/test/scala/gem/util/FormatSpec.scala

@@ -26,7 +26,7 @@ final class FormatSpec extends CatsSuite {
     forAll { (n: Int) =>
       Either.catchNonFatal(example.unsafeGet(n)) match {
         case Left(t)  => t.getMessage shouldEqual s"unsafeGet failed: $n"
-        case Right(b) => true
+        case Right(_) => true
       }
     }
   }

modules/ctl/src/main/scala/low/docker.scala

@@ -66,7 +66,7 @@ object docker {
 
   def allContainerNames: CtlIO[List[String]] =
     docker("ps", "-a", "--format", "{{.Names}}").require {
-      case Output(o, ss) => ss
+      case Output(_, ss) => ss
     }
 
   def getLabelValue(label: String, k: Container): CtlIO[String] =

modules/ephemeris/src/main/scala/gem/horizons/HorizonsNameQuery.scala

@@ -97,7 +97,7 @@ object HorizonsNameQuery {
               f(offsets).map(g => rows.takeWhile(_.trim.nonEmpty).map(g)).toRight("Not enough columns.")
             } catch {
               case    nfe: NumberFormatException           =>  ("Number format exception: " + nfe.getMessage).asLeft
-              case sioobe: StringIndexOutOfBoundsException =>   "Column value(s) not found.".asLeft
+              case      _: StringIndexOutOfBoundsException =>   "Column value(s) not found.".asLeft
             }
         })
 

modules/ephemeris/src/test/scala/gem/horizons/HorizonsUpdaterApp.scala

@@ -56,7 +56,7 @@ object HorizonsUpdaterApp {
         keys.traverse { keyStr =>
           EphemerisKey.fromString.getOption(keyStr) match {
             case Some(key: EphemerisKey.Horizons) => Either.right(key)
-            case Some(key)                        => Either.left(s"'$keyStr' is not an horizons key")
+            case Some(_)                          => Either.left(s"'$keyStr' is not an horizons key")
             case None                             => Either.left(s"Could not parse '$keyStr' as an horizons key")
           }
         }

modules/ocs2/src/main/scala/gem/ocs2/Importer.scala

@@ -57,7 +57,7 @@ object Importer extends DoobieClient {
       for {
         _ <- l.log(u, s"remove program ${p.id}"       )(rmProgram           )
         _ <- l.log(u, s"insert new version of ${p.id}")(ProgramDao.insert(p))
-        _ <- p.observations.toList.traverse_ { case (i,o) =>
+        _ <- p.observations.toList.traverse_ { case (i, _) =>
                val oid = Observation.Id(p.id, i)
                l.log(u, s"write datasets for $oid")(datasets.write(oid, dsMap(oid)))
              }