Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization: Changed write order for extrude, tessellate, altitudeModeGroup #25

Merged
merged 20 commits into from
Apr 5, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 4, 2022

Changed write order on serialization for extrude, tessellate for write_point() and extrude, tessellate, altitudeMode for write_geom_props so that the result validates against http://schemas.opengis.net/kml/2.2.0/ogckml22.xsd

@pjsier
Copy link
Member

pjsier commented Apr 4, 2022

This is just an issue of the tests now being out of date with the representation. You can update test_write_point and test_write_polygon to put the correct attributes first so that this passes. Also feel free to add the change for #23 here

jenslar added 7 commits April 5, 2022 09:43
Write custom elements before geometry for `write_placemark` to validate against http://schemas.opengis.net/kml/2.2.0/ogckml22.xsd.
Changed the test representation strings for Point and Polygon to correspond to new write order in write_point and write_geom_props.
Serialization: Fix tests for Point and Polygon
…e-tests-1"

This reverts commit b6ffb4c, reversing
changes made to e17c1ba.
@ghost
Copy link
Author

ghost commented Apr 5, 2022

Ok, I changed the order for custom elements/children in write_placemark and tried updating the Point+Polygon tests as well.

However, the tests still fail since write_polygon now also needs write order changed. What I've changed the string representation to for test_write_point and test_write_polygon validates against http://schemas.opengis.net/kml/2.2.0/ogckml22.xsd so far.

I can look into write_polygon this as well if you'd like, but should that be in another PR or this one?

@pjsier
Copy link
Member

pjsier commented Apr 5, 2022

Feel free to put the changes to write_polygon in here as well. It also looks like there are some formatting issues in CI

jenslar added 2 commits April 5, 2022 14:36
Serialization: Fix write order for write_polygon
@ghost
Copy link
Author

ghost commented Apr 5, 2022

I've changed write order in write_polygon and the formatting issue in test_write_point. Seems to pass tests now.

@pjsier
Copy link
Member

pjsier commented Apr 5, 2022

Thanks for making those updates! I think this should be good, but I'll try to take a closer look later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants