-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialization: Changed write order for extrude, tessellate, altitudeModeGroup #25
Conversation
Changing write order when serializing elements in Point to comply with http://schemas.opengis.net/kml/2.2.0/ogckml22.xsd.
Changing write order when serializing elements in multi-point geometries to comply with http://schemas.opengis.net/kml/2.2.0/ogckml22.xsd.
Fixing serialization for Point
…point Fixing serialization for multi-point geometries
Removed semi-colon for return value, added missing semi-colon
Fixing resulting values
This reverts commit 43b189e.
This is just an issue of the tests now being out of date with the representation. You can update |
Write custom elements before geometry for `write_placemark` to validate against http://schemas.opengis.net/kml/2.2.0/ogckml22.xsd.
Fix placemark serialization
Changed the test representation strings for Point and Polygon to correspond to new write order in write_point and write_geom_props.
Serialization: Fix tests for Point and Polygon
Fixing tests for Point and Polygon
Ok, I changed the order for custom elements/children in write_placemark and tried updating the Point+Polygon tests as well. However, the tests still fail since I can look into |
Feel free to put the changes to |
Moved `write_geom_props` for `write_polygon` to comply with http://schemas.opengis.net/kml/2.2.0/ogckml22.xsd.
Serialization: Fix write order for write_polygon
I've changed write order in |
Thanks for making those updates! I think this should be good, but I'll try to take a closer look later today |
Changed write order on serialization for
extrude
,tessellate
forwrite_point()
andextrude
,tessellate
,altitudeMode
forwrite_geom_props
so that the result validates against http://schemas.opengis.net/kml/2.2.0/ogckml22.xsd