Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization: Changed write order for extrude, tessellate, altitudeModeGroup #25

Merged
merged 20 commits into from
Apr 5, 2022
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
7cbb838
Fixing serialization for Point
jenslar Apr 4, 2022
4bfa15f
Fixing serialization for multi-point geometries
jenslar Apr 4, 2022
6ea6745
Merge pull request #1 from blipmusic/blipmusic-patch-serialize-point
jenslar Apr 4, 2022
e6d0519
Merge pull request #2 from blipmusic/blipmusic-patch-serialize-multi-…
jenslar Apr 4, 2022
3f0e330
Add + remove semi-colon
jenslar Apr 4, 2022
a857145
Fix result
jenslar Apr 4, 2022
1a3c5ef
Change write order of elements write_geom_props
jenslar Apr 4, 2022
2348271
Fix return value of write_geom_props
jenslar Apr 4, 2022
b79627c
Fix expression in write_geom_props
jenslar Apr 4, 2022
43b189e
Write geometry last for write_placemark
jenslar Apr 4, 2022
0c335c9
Revert "Write geometry last for write_placemark"
jenslar Apr 4, 2022
896536a
Fixing placemark serialization
jenslar Apr 5, 2022
bf8a9c7
Merge pull request #3 from blipmusic/blipmusic-patch-serialize-placemark
jenslar Apr 5, 2022
953732a
Serialization: Fix tests for Point and Polygon
jenslar Apr 5, 2022
e17c1ba
Merge pull request #4 from blipmusic/blipmusic-patch-serialize-tests
jenslar Apr 5, 2022
0b756ea
Fixing tests for Point and Polygon
jenslar Apr 5, 2022
b6ffb4c
Merge pull request #5 from blipmusic/blipmusic-patch-serialize-tests-1
jenslar Apr 5, 2022
2956a71
Revert "Merge pull request #5 from blipmusic/blipmusic-patch-serializ…
jenslar Apr 5, 2022
f4ebf00
Serialization: Fix write order for write_polygon
jenslar Apr 5, 2022
931ed31
Merge pull request #6 from blipmusic/blipmusic-patch-serialize-polygon
jenslar Apr 5, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 19 additions & 18 deletions src/writer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,9 @@ where
fn write_point(&mut self, point: &Point<T>) -> Result<(), Error> {
self.writer
.write_event(Event::Start(BytesStart::owned_name(b"Point".to_vec())))?;
self.write_text_element(b"coordinates", &point.coord.to_string())?;
self.write_text_element(b"altitudeMode", &point.altitude_mode.to_string())?;
self.write_text_element(b"extrude", if point.extrude { "1" } else { "0" })?;
self.write_text_element(b"altitudeMode", &point.altitude_mode.to_string())?;
self.write_text_element(b"coordinates", &point.coord.to_string())?;
Ok(self
.writer
.write_event(Event::End(BytesEnd::owned(b"Point".to_vec())))?)
Expand Down Expand Up @@ -184,6 +184,12 @@ where
BytesStart::owned_name(b"Polygon".to_vec())
.with_attributes(self.hash_map_as_attrs(&polygon.attrs)),
))?;
self.write_geom_props(GeomProps {
coords: Vec::new(),
altitude_mode: polygon.altitude_mode,
extrude: polygon.extrude,
tessellate: polygon.tessellate,
})?;
self.writer
.write_event(Event::Start(BytesStart::owned_name(
b"outerBoundaryIs".to_vec(),
Expand All @@ -203,12 +209,6 @@ where
self.writer
.write_event(Event::End(BytesEnd::borrowed(b"innerBoundaryIs")))?;
}
self.write_geom_props(GeomProps {
coords: Vec::new(),
altitude_mode: polygon.altitude_mode,
extrude: polygon.extrude,
tessellate: polygon.tessellate,
})?;
Ok(self
.writer
.write_event(Event::End(BytesEnd::borrowed(b"Polygon")))?)
Expand Down Expand Up @@ -237,12 +237,12 @@ where
if let Some(description) = &placemark.description {
self.write_text_element(b"description", description)?;
}
if let Some(geometry) = &placemark.geometry {
self.write_geometry(geometry)?;
}
for c in placemark.children.iter() {
self.write_element(c)?;
}
if let Some(geometry) = &placemark.geometry {
self.write_geometry(geometry)?;
}
Ok(self
.writer
.write_event(Event::End(BytesEnd::borrowed(b"Placemark")))?)
Expand Down Expand Up @@ -439,6 +439,9 @@ where
}

fn write_geom_props(&mut self, props: GeomProps<T>) -> Result<(), Error> {
self.write_text_element(b"extrude", if props.extrude { "1" } else { "0" })?;
self.write_text_element(b"tessellate", if props.tessellate { "1" } else { "0" })?;
self.write_text_element(b"altitudeMode", &props.altitude_mode.to_string())?;
if !props.coords.is_empty() {
self.write_text_element(
b"coordinates",
Expand All @@ -448,11 +451,9 @@ where
.map(Coord::to_string)
.collect::<Vec<String>>()
.join("\n"),
)?;
)?
}
self.write_text_element(b"altitudeMode", &props.altitude_mode.to_string())?;
self.write_text_element(b"extrude", if props.extrude { "1" } else { "0" })?;
self.write_text_element(b"tessellate", if props.tessellate { "1" } else { "0" })
Ok(())
}

fn write_container(
Expand Down Expand Up @@ -520,7 +521,7 @@ mod tests {
altitude_mode: types::AltitudeMode::RelativeToGround,
..Default::default()
});
assert_eq!("<Point><coordinates>1,1,1</coordinates><altitudeMode>relativeToGround</altitudeMode><extrude>0</extrude></Point>", kml.to_string());
assert_eq!("<Point><extrude>0</extrude><altitudeMode>relativeToGround</altitudeMode><coordinates>1,1,1</coordinates></Point>", kml.to_string());
}

#[test]
Expand Down Expand Up @@ -604,10 +605,10 @@ mod tests {
});

assert_eq!(
r#"<Polygon><outerBoundaryIs><LinearRing><coordinates>-1,2,0
r#"<Polygon><extrude>0</extrude><tessellate>0</tessellate><altitudeMode>clampToGround</altitudeMode><outerBoundaryIs><LinearRing><extrude>0</extrude><tessellate>1</tessellate><altitudeMode>clampToGround</altitudeMode><coordinates>-1,2,0
-1.5,3,0
-1.5,2,0
-1,2,0</coordinates><altitudeMode>clampToGround</altitudeMode><extrude>0</extrude><tessellate>1</tessellate></LinearRing></outerBoundaryIs><altitudeMode>clampToGround</altitudeMode><extrude>0</extrude><tessellate>0</tessellate></Polygon>"#,
-1,2,0</coordinates></LinearRing></outerBoundaryIs></Polygon>"#,
kml.to_string()
);
}
Expand Down