Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Protobuf format response #1475

Closed
wants to merge 2 commits into from

Conversation

salamer
Copy link
Contributor

@salamer salamer commented Aug 12, 2018

Gin now have the protobufBinding function to check the request format, but didn't have a protobuf response function like c.YAML().
In our company ByteDance, the largest internet company using golang in China, we use gin to transfer Protobuf instead of Json, we have to write some internal library to make some wrappers to achieve that, and the code is not elegant. So we really want such a feature.

@codecov
Copy link

codecov bot commented Aug 12, 2018

Codecov Report

Merging #1475 into master will decrease coverage by 0.57%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1475      +/-   ##
==========================================
- Coverage   98.88%   98.31%   -0.58%     
==========================================
  Files          36       37       +1     
  Lines        1887     1898      +11     
==========================================
  Hits         1866     1866              
- Misses         16       27      +11     
  Partials        5        5
Impacted Files Coverage Δ
render/render.go 100% <ø> (ø) ⬆️
context.go 98.97% <0%> (-0.52%) ⬇️
render/protobuf.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e64d32...73b20fd. Read the comment docs.

@appleboy
Copy link
Member

duplicated of #1477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants