Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Protobuf format response and test #1477

Closed
wants to merge 3 commits into from

Conversation

salamer
Copy link
Contributor

@salamer salamer commented Aug 12, 2018

Gin now have the protobufBinding function to check the request format, but didn't have a protobuf response function like c.YAML().
In our company ByteDance, the largest internet company using golang in China, we use gin to transfer Protobuf instead of Json, we have to write some internal library to make some wrappers to achieve that, and the code is not elegant. So we really want such a feature.

The last pull request was blocked because I forgot to write the unit test. This time I have added the unit test, using the protobuf in the grpc example.

@thinkerou
Copy link
Member

duplicated #1479
@salamer If you change the pull request, please commit not new pull request. you should use git command.

@thinkerou thinkerou closed this Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants