Stop target process immediately after execve. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,7 +30,7 @@ func WithTestProcess(name string, t *testing.T, fn testfunc) { | |||
| } | |||
| defer os.Remove("./" + base) | |||
|
|
|||
| p, err := proctl.AttachBinary("./" + base) | |||
| p, err := proctl.AttachBinary("./" + base, true) | |||
There was a problem hiding this comment.
The arity of AttachBinary hasn't changed.
|
Have another look. |
|
LGTM - merged. |
nclifton
pushed a commit
to nclifton/delve
that referenced
this pull request
Feb 24, 2021
* Process MO worker * Fix the empty accountRPC client and changed sender on account to array * Removed mongo install from the main backend dockerfile * Make sure we check we are sending with a valid sender * Implement the mo webhook * Ported the runtest script * Fixed/removed borken tests * Fixed up linting * Set alaris username and password from account with optional url for the alaris endpoint (so you can use tualet instead) * Ommit last message if its not set * removed log * Fix multipart check * Removed wayward binary * Add redis to sms service db * Store multipart MO parts in redis and combine when we have all parts * Maek tualet send mo parts with a random delay.. just liek real servers * Export the redis port to the local machine * Updated gitignore * Removed _ from id in account * Optimised the return logic at the end of process mo * Fix retry on rate limit hit * Return on error when sending dlrs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way of launching to be debugged processes is kind of racy. They are
started and then get sent a SIGSTOP. This results in the target being stopped
at a more or less arbitrary point. There is explicit support for launching to
be traced processes in os/exec. By setting SysProcAttr.Ptrace we can make the
target process stop immediately after the execve.