Pause execution and return to CLI on ^C #15
Conversation
Looks like it can't find/open the source file in command.printcontext(). |
| @@ -73,6 +74,15 @@ func main() { | |||
| die(1, "Could not start debugging process:", err) | |||
| } | |||
|
|
|||
| ch := make(chan os.Signal) | |||
There was a problem hiding this comment.
I would move this logic down to after the switch where we try all of the different ways to attach to a process. The start() local function was removed by #12 so be sure to rebase on top of master to pull in changes to main().
Also, the start() function is only run when executing a binary on behalf of the user, so in the case of attaching to an already running process this signal handler would never get registered. Putting this at the end of the switch in main will ensure this signal handler is registered regardless of how we attach to the process.
|
Closing this PR and opening an issue due to inactivity. Issue is #30. |
* fix #3 * still troubleshooting delve derekparker/delve#15
* Initial commit for track link service * fix track_link migration * add rpc and db methods for track link - creating track links (still need to add generation of track link id) - finding track link by track link id - incrementing hits for track link * name is now track_link * rpc method to replace urls with track links - still need to add postgres function to automagically generate the tracklinkids * track links cannot be https * rename mms shorten_urls column to track_links * rename New client function to NewClient * add track links column to sms * rename rpc methods to match spec * add message_type column to track link * use track link service to shorten links in sms/mms * rename GenerateShortUrls to GenerateTrackLinks - coz they're not short urls they're track links duh * add track_link_generate function to db - given an int length generate a track link id - checks to see if id already exists in track link table and will generate another if it does - let's see whether this is sufficient... * fix up modd after rebase
Consider this a feature request with a prototype, I guess, because I get the following when I actually try to use this:
Is this just what happens when it stops in the runtime guts rather than go-land?