-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project crashes when pressing any key in v4.4-dev6 and when rolling back to v4.4-dev5 (custom editor shortcuts) #100182
Comments
Without the project no one can help you (and the trace is useless) |
I know you mean well, but this sounds quite dismissive, please pay attention to the way you phrase things. @caioraphael1 Can you try making your custom build with The problem might be related to changes in the InputMap. Could you share the contents of your control mappings in |
I couldn't reproduce this in a simple project. If you can't share the project or a MRP that triggers the issue, it would also be helpful if you could try to figure out what feature your project is using that might trigger this issue. I notice this in the logs:
That's not a Godot message, I assume it comes from a thirdparty plugin? |
Given the message text I think the plugin is: |
Same issue here with 4.4dev6 and corresponding godot_cpp from Master. On debug start I observe various gdextension controls firing _ready() and completing, but it crashes before the next control in the tree fires. Lib is built with debug_symbols=yes. VS reporting "exited with code 3221225477 (0xc0000005) Access violation". In the meantime I'll keep checking my code to see if I've missed a nullptr assignment and will post if any progress.
Debug output from VS2022:
|
@GameArchitekt To get more information you'd need to build the Godot editor with |
Thanks, will give that a go to try and assist. I've been putting off building the editor as I'm only 2 months into using C++ (having spent two decades using C#). |
I'm not too familiar with the building systems, but I'll give it a try. For more context, I've made the following this since I upgraded to dev6, but I don't know if any of these are responsible:
I haven't changed any InputMap while in dev6. |
The problem is happening in 4 different projects related to my main project. The project I just sent is the Gateway Server for my game. I haven't made any changes to this project since I've upgraded to dev6. The project doesn't even have a InputMap set, but if I press any key, the project crashes. |
Well that went a lot smoother than expected (apart from a bug when using target=template_debug, removing fixed). Here's your improved debug output...
|
How do I know which commit represents the 4.4-dev6, to make a build with debug symbols? |
It's [1f47e4c], you can find it on the release blog near the bottom |
In my instance this looks more like bugs in my code not checking for nullptr or indexes outside array size rather than in Godot. |
Trace of 4.4-dev6, using debug symbols.
|
Can't test the MRP because of the removed certificates, so some other change to make it run would be needed to test this |
here's the new MRP: mrp.zip |
Cannot confirm with just this MRP, running the project directly, are there any specific steps required? (I did not try the rollback to dev5 only running it and trying input) |
The project opens normally, but if any key is pressed while the project is open, it crashes |
Then something more is needed as I cannot replicate that from the MRP Have you confirmed it happens when running the MRP? Exactly as it is packaged? |
yes, right before I zipped the file I tested opening the project and if I press any keys, the project crashes. I just tested it again and it crashes as explained. I have included the .godot folder, as I thought that could be useful in this case. I'm using 4.4-dev6, the official build released in the blog. Using the custom build with debug symbols the crash still happened. In this case, I get the log shown in some comments above. |
It's actually related to the Why? No ideia. Tho, as mentioned, when I upgraded from a custom 4.4-dev5 build to the 4.4-dev6, I've made some changes to some hotkeys. My |
Stacktrace for @caioraphael1's MRP and editor settings from #100182 (comment) on Linux in the latest
I suspect that it's a combination of #98891 which doesn't properly validate the I can make a quick fix for the first part (missing validation check). For the corrupted shortcuts in Editor Settings, if my hunch is correct, this was just bad luck from testing 4.4-dev4 which introduced a compat breaking change to input events, which we reverted in dev5, but with compatibility code only for Project Settings, not Editor Settings. You can fix this locally by removing/redoing the editor custom hotkeys. |
I have tried to reproduce the crash, but I was unable to do so, using the MRP with the provided Editor Settings (I have copied the editor settings to So I'm not sure, what I'm doing different - it would be great for me, to be able to cause the crash in order to identify the reason for the invalid shortcuts. Looking at the code of Edit: |
Ok, I'm confused. It's only this entry in the entire file that's causing issues:
As shown in the video, if I remove the shortcut for 2024-12-10.10-58-43.mp4 |
Is the issue really completed? It seems like the |
The reason your shortcut was invalid is either:
|
Tested versions
System information
windows 10, Forward+, GTX 1660, Ryzen 3300x, 16GB RAM
Issue description
If I execute the project and press any keys in the keyboard the project crashes leaving the following trace:
I was using 4.4-dev5 as I needed a new feature regarding RPCs. I had to go to v4.4.dev.custom_build.0c45ace15 to revert the Clock Syncing changes that were making impossible to work in my project. I then upgraded to 4.4-dev6.
Now, the project crashes even if I go back to v4.4.dev.custom_build.0c45ace15.
I've tried deleting the
.godot
,appdata/local/godot
and theappdata/roaming/godot/app_userdata/_project_name_/
folder after rolling back to v4.4.dev.custom_build.0c45ace15, but still crashes.Steps to reproduce
:/
Minimal reproduction project (MRP)
This is happening in my main project.
The text was updated successfully, but these errors were encountered: