Revert "Fix InputEvent device id clash" and add a compatibility function
#99449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 916d480. Revert "Fix InputEvent crash when opening project" This reverts commit abb9c0f. Introduce a compatibility function for projects affected by the device id clash reversal Since the reverted PR introduced changes in the project.godot file, it seems prudent to introduce a compatibility function for such affected projects.
Sauermann
force-pushed
the
fix-revert-device-id-clash
branch
from
de0c757 to
bc5e2f9
Compare
akien-mga
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Makes sense to me, I agree we should undo the compat breakage and reconsider how to solve the original issue in a better way.
The added compatibility code for users of previous dev snapshot makes sense to ease the transition, and we can remove it before 4.4-stable.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InputEventdevice id clash (reverted) #97707Since the reverted PR introduced changes in the project.godot file, it seems prudent to introduce a compatibility function for such affected projects.
Updated 2024-11-20: Squashed commits together.