Remove temporary project conversion #99479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Nov 20, 2024
This project conversion should be removed before the next stable release, because it affects only projects opened during dev-builds.
Sauermann
force-pushed
the
fix-remove-project-conversion
branch
from
6c0c122 to
ee2930c
Compare
|
I have updated the PR to additionally revert #100334. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project conversion affects only projects, that were edited after #97707 (v4.4-dev4) and provides an easy way to upgrade these projects.
It seems reasonable to assume, that at that time of the next stable Godot-release all affected projects have been converted.
So I would like to suggest to merge this PR and remove the project conversion shortly before the next stable release,
For projects, that haven't been converted, we can provide an upgrade-strategy, that that consists of opening the project once with v4.4-dev5.
Follow-up to/Implements #99449 (review)