Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing Editor Shortcuts is added to Scene History #76851

Closed
me2beats opened this issue May 8, 2023 · 4 comments · Fixed by #100120
Closed

Changing Editor Shortcuts is added to Scene History #76851

me2beats opened this issue May 8, 2023 · 4 comments · Fixed by #100120
Labels
bug topic:editor
Milestone
4.4

Comments

@me2beats
Copy link

me2beats commented May 8, 2023

Godot version

4

System information

Windows

Issue description

image

Steps to reproduce

  • add a scene
  • change something in Editor-Shortcuts

Minimal reproduction project
@Calinou
Copy link
Member

Calinou commented May 8, 2023

I believe this occurs with all editor setting changes, but I agree these shouldn't be stored in undo/redo. Project setting changes should be stored in undo/redo though.

@me2beats
Copy link
Author

me2beats commented May 8, 2023 •
edited
Loading

only with Shortcuts
for example I change idle_parse_delay, and it is visible only if Global is checked

@KoBeWi
Copy link
Member

KoBeWi commented May 8, 2023

Seems like duplicate of #73755?

@allenwp allenwp mentioned this issue Dec 5, 2024
Closed
@allenwp
Copy link
Contributor

allenwp commented Dec 5, 2024 •
edited
Loading

PR #100120 should fix this bug: it makes changing editor shortcuts appear in global history instead of scene history.

allenwp added a commit to allenwp/godot that referenced this issue Dec 6, 2024
@allenwp
EditorUndoRedoManager: Use fixed history when a custom context is p…
85be143 
…rovided.

This makes the custom context feature of the `EditorUndoRedoManager` behave consistently with the current documentation.
Fixes godotengine#100108. Also fixes godotengine#76851 by providing a custom context when creating the "Edit Shortcut" action.
@allenwp allenwp mentioned this issue Dec 6, 2024
Merged
@AThousandShips AThousandShips added this to the 4.4 milestone Dec 13, 2024
tGautot pushed a commit to tGautot/godot that referenced this issue Feb 5, 2025
@allenwp @tGautot
Forced fixed undo history to make editor shortcuts use global history.
74809c1 
Fixes godotengine#76851.
tGautot pushed a commit to tGautot/godot that referenced this issue Feb 5, 2025
@allenwp @tGautot
Forced fixed undo history to make editor shortcuts use global history.
4846bfc 
Fixes godotengine#76851.
WhalesState pushed a commit to WhalesState/blazium that referenced this issue Mar 17, 2025
@allenwp @WhalesState
Forced fixed undo history to make editor shortcuts use global history.
d26202b 
Fixes godotengine#76851.
WhalesState pushed a commit to WhalesState/blazium that referenced this issue Mar 17, 2025
@allenwp @WhalesState
Forced fixed undo history to make editor shortcuts use global history.
45fbfe6 
Fixes godotengine#76851.
WhalesState pushed a commit to WhalesState/blazium that referenced this issue Mar 20, 2025
@allenwp @WhalesState
Forced fixed undo history to make editor shortcuts use global history.
4da6ec2 
Fixes godotengine#76851.
WhalesState pushed a commit to WhalesState/blazium that referenced this issue Mar 20, 2025
@allenwp @WhalesState
Forced fixed undo history to make editor shortcuts use global history.
48ccb02 
Fixes godotengine#76851.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.4
5 participants
@Calinou @KoBeWi @me2beats @allenwp @AThousandShips