EditorUndoRedoManager: Use fixed history when a custom context is provided
#100061
Conversation
allenwp
force-pushed
the
force-fixed-history-for-custom-context
branch
from
905a619 to
259c556
Compare
| @@ -150,6 +150,7 @@ void EditorUndoRedoManager::create_action(const String &p_name, UndoRedo::MergeM | |||
| if (p_custom_context) { | |||
| // This assigns history to pending action. | |||
| get_history_for_object(p_custom_context); | |||
| force_fixed_history(); | |||
There was a problem hiding this comment.
force_fixed_history() is supposed to be called manually. EditorUndoRedoManager will automatically deduce optimal history, if you force a different one it might lead to bugs. The method should be used if automatic history fails (there are some cases where it can't be determined), but you know that the forced one is correct.
There was a problem hiding this comment.
Without a change similar to this one, the custom_context parameter of create_action does not always function correctly (or maybe it never functions correctly). If you want, I can open a new issue describing this in more detail?
There was a problem hiding this comment.
Feel free to open it, but it might be misunderstanding.
There was a problem hiding this comment.
I've filed an issue to better describe the issue that this PR aims to resolve: #100108
…rovided. This makes the custom context feature of the `EditorUndoRedoManager` behave consistently with the current documentation. Fixes godotengine#100108. Also fixes godotengine#76851 by providing a custom context when creating the "Edit Shortcut" action.
allenwp
force-pushed
the
force-fixed-history-for-custom-context
branch
from
259c556 to
85be143
Compare
|
Tried to rename my branch because this wasn't the correct solution. I'll link a new PR here in a moment that has a better fix. |
|
You can push a new commit and change the title, branch name does not matter. |
|
New PR with different approach: #100120 |
This makes the custom context feature of the
EditorUndoRedoManagerbehave consistently with the current documentation.Fixes #100108. Also fixes #76851 by providing a custom context when creating the "Edit Shortcut" action.