Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC fails to build and detect compilers for vs preview after #91069 #97619

Closed
HKunogi opened this issue Sep 29, 2024 · 3 comments · Fixed by #97622
Closed

MSVC fails to build and detect compilers for vs preview after #91069 #97619

HKunogi opened this issue Sep 29, 2024 · 3 comments · Fixed by #97622

Comments

@HKunogi
Copy link
Contributor

HKunogi commented Sep 29, 2024

Tested versions

After this commit it fails to compile while using vs studio preview, the change on methods.py should take into account for preview versions by using the '-prerelease' flag on the command, and also take into account the return of the 'Preview' keyword on the result to properly parse the returned value.

System information

Windows 11

Issue description

Cannot build due to failure on detecting compiler when using vs studio preview, it used to work prior to the specified commit.

Steps to reproduce

Simply install vs studio preview (without any other versions installed) and try to build it using the scons script

Minimal reproduction project (MRP)

Build issue, so theres no MRP

@akien-mga
Copy link
Member

Thanks for the report. It's a duplicate of #97614 so I'll consolidate it there. A fix will be merged shortly.

@akien-mga
Copy link
Member

I misunderstood, this isn't a duplicate but specific to VS Preview.

@HKunogi
Copy link
Contributor Author

HKunogi commented Sep 30, 2024

@akien-mga @Repiteo It stills shows the issue due to the int parsing of the script, given the return string from vswhere when having preview versions differing from the normal ones.
image
in this case the sem_ver[2] contains "0 Preview 2.1".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Immediate Blocker
Development

Successfully merging a pull request may close this issue.

3 participants