Fix parsing preview MSBuild versions

[GerardSmit]

Running scons while having a preview version of MSBuild installed (with Visual Studio Preview) will result in the following error:

$ scons
scons: Reading SConscript files ...
Automatically detected platform: windows
Auto-detected 24 CPU cores available for build parallelism. Using 23 cores by default. You can override it with the `-j` or `num_jobs` arguments.
Using SCons-detected MSVC version 14.3, arch x86_64
Building for platform "windows", architecture "x86_64", target "editor".
ValueError: invalid literal for int() with base 10: '0 Preview 2':
  File "C:\Sources\redot-engine\SConstruct", line 642:
    cc_version = methods.get_compiler_version(env)
  File "C:\Sources\redot-engine\methods.py", line 831:
    ret["patch"] = int(sem_ver[2])

The Visual Studio Preview that I have installed is: 17.12.0 Preview 2.1

After checking, in methods.py the catalog version is being split by the '.' character, which results in the following array:

["17", "12", "0 Preview 2", "1"]
 ^^^   ^^^^  ^^^^^^^^^^^^^  ^^^
  |     |         |          |
  |     |         |          +--- Unused/invalid
  |     |         +--- Patch
  |     +--- Minor
  +--- Major

Then the patch version is being converted to an integer, which fails because it contains non-numeric characters.

This PR checks if the version has a space in it and trims everything after the space; causing the conversion to succeed.

Screenshot of Visual Studio Installer

[Norrox]

nice

[GerardSmit]

I just found out that in upstream this is issue godotengine/godot#97619 and was fixed with PR godotengine/godot#97639.

After rebasing with upstream this issue is also fixed, so maybe this PR is not needed.

[filipworksdev]

The fix from upstream patch is simpler but I like the comment explanation for the change in this pr. I guess we don't really need this one, right? Esentially what they do is they use the patch "1 Preview 2".split()[0] which is 1. Simple solution but it doesn't explain why.

[GerardSmit]

The upstream branch has been merged to this repository, so this issue no longer persists.