SCons: Fix MSVC version check for VS Preview #97639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repiteo
approved these changes
Sep 30, 2024
|
Looks like the codestyle check is failing, but that's fine as it'd be addressed with my above suggestion. Just amend the commit and you'll be good to go! |
Done, applied it. |
akien-mga
changed the title
|
I pushed a rebase to squash the two commits into one. This should now be ready to merge. |
akien-mga
approved these changes
Oct 2, 2024
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Congrats @HKunogi . I hope that there is a place to collaborate for just devs that have contributed. We have often tried to discuss on discord but it's often just users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This alters the methods.py check for patch semantic version to account for "A Preview B.C" case in where it takes A as the patch version, otherwise, proceed as normal.
Related to: #97619