Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide NavigationRegion2D's debug instance instead of freeing it, and hide it when navigation_polygon is set to null. #100006

Merged

Conversation

Daylily-Zeleen
Copy link
Contributor

@Daylily-Zeleen Daylily-Zeleen commented Dec 4, 2024

An alternative of #99948.


I guess we could remove the navigation_polygon.is_valid() check in the notification draw function instead as that should clear the debug canvas item instance and the debug mesh without freeing the entire rendering RIDs. Although there are likely some missing checks then in the later functions.

@smix8 I can't find the " navigation_polygon.is_valid() check" that can be removed. Could your point it out?

@Daylily-Zeleen Daylily-Zeleen requested a review from a team as a code owner December 4, 2024 10:09
@AThousandShips AThousandShips added this to the 4.4 milestone Dec 4, 2024
@AThousandShips AThousandShips requested a review from a team December 4, 2024 10:30
@Repiteo Repiteo requested a review from smix8 December 5, 2024 19:34
@Repiteo Repiteo merged commit cc59949 into godotengine:master Dec 9, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 9, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants