Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free debug mesh when NavigationRegion2D's navigation_polygon is set to null. #99948

Conversation

Daylily-Zeleen
Copy link
Contributor

@Daylily-Zeleen Daylily-Zeleen commented Dec 3, 2024

Make NavigationRegion2D(free debug elements) similar to NavigationRegion3D(make debug elements invisible).

… to null.
@Daylily-Zeleen Daylily-Zeleen requested a review from a team as a code owner December 3, 2024 03:26
@akien-mga akien-mga requested a review from a team December 3, 2024 08:35
@akien-mga akien-mga added this to the 4.4 milestone Dec 3, 2024
@akien-mga akien-mga changed the title Free debug mesh when NavigationRegion2D's navigation_polygon is set to null. Free debug mesh when NavigationRegion2D's navigation_polygon is set to null. Dec 3, 2024
@smix8
Copy link
Contributor

smix8 commented Dec 3, 2024

I guess we could remove the navigation_polygon.is_valid() check in the notification draw function instead as that should clear the debug canvas item instance and the debug mesh without freeing the entire rendering RIDs. Although there are likely some missing checks then in the later functions.

The NavigationRegion3D also only hides the visibility of the debug instance instead of freeing the RIDs.

Copy link
Contributor

@smix8 smix8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned I would prefer if the rendering RIDs could be kept someway but if that turns out too much change is needed I am fine merging at is.

@akien-mga
Copy link
Member

Superseded by #100006.

@akien-mga akien-mga closed this Dec 12, 2024
@akien-mga akien-mga removed this from the 4.4 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants