Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCons: Use more native to scons approach for scu #100148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Dec 7, 2024

Followup to #98888. Note here can't be any regressions like #99607 because here separator is not OS dependent and set explicitly

Followup to godotengine#98888. Note here can't be any regressions like godotengine#99607
because here separator is not OS dependent and set explicitly

Signed-off-by: Yevhen Babiichuk (DustDFG) <dfgdust@gmail.com>
@dustdfg dustdfg requested a review from a team as a code owner December 7, 2024 16:53
@AThousandShips AThousandShips added this to the 4.x milestone Dec 7, 2024
Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Repiteo Repiteo modified the milestones: 4.x, 4.4 Dec 9, 2024
@akien-mga akien-mga requested a review from lawnjelly December 9, 2024 12:27
@lawnjelly
Copy link
Member

I'll leave this to you guys.
As I said in the previous issue, I agree with the best practices, PRs should be there to solve a problem.

https://docs.godotengine.org/en/stable/contributing/development/best_practices_for_engine_contributors.html

@Repiteo Repiteo modified the milestones: 4.4, 4.x Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants